linux: write a unit test for plugin mime parsing

linux: write a unit test for plugin mime parsing

No significant code change, just preparing to redo the parsing
code and thinking I needed test coverage.

(Since the parse can fail now, made the parse error out
rather than continuing when it's unable to parse some fields.
This will have more failure cases in the next version of this
code.)

[piman, 2009-09-08 22:48:29]

http://codereview.chromium.org/193046/diff/2001/2003
File webkit/glue/plugins/plugin_lib_linux.cc (right):

http://codereview.chromium.org/193046/diff/2001/2003#newcode86
Line 86: base::UnloadNativeLibrary(dl);
We didn't use to do that. Now, it sounds like a good thing to do, but shouldn't
we do it whether we successfully parsed or not ?

[Evan Martin, 2009-09-08 22:54:28]

updated with one additional test of japanese input

http://codereview.chromium.org/193046/diff/2001/2003
File webkit/glue/plugins/plugin_lib_linux.cc (right):

http://codereview.chromium.org/193046/diff/2001/2003#newcode86
Line 86: base::UnloadNativeLibrary(dl);
On 2009/09/08 22:48:30, piman wrote:
> We didn't use to do that. Now, it sounds like a good thing to do, but
shouldn't
> we do it whether we successfully parsed or not ?

Before, this parse couldn't fail, so we never had the error case.  We unload in
the success case on L109 below.

[Evan Martin, 2009-09-08 23:02:31]

updated the description with what the functional change i made was

[piman, 2009-09-08 23:04:15]

LGTM. Thanks for the UTF8 test.

http://codereview.chromium.org/193046/diff/2001/2003
File webkit/glue/plugins/plugin_lib_linux.cc (right):

http://codereview.chromium.org/193046/diff/2001/2003#newcode86
Line 86: base::UnloadNativeLibrary(dl);
On 2009/09/08 22:54:28, Evan Martin wrote:
> On 2009/09/08 22:48:30, piman wrote:
> > We didn't use to do that. Now, it sounds like a good thing to do, but
> shouldn't
> > we do it whether we successfully parsed or not ?
> 
> Before, this parse couldn't fail, so we never had the error case.  We unload
in
> the success case on L109 below.

NVM, brain fart. I thought the } below was the end of the function.