Issue 193033: Linux: expose "Use system title bar and borders" preference in options dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193033: Linux: expose "Use system title bar and borders" preference in options dialog. (Closed)

Created:
11 years, 3 months ago by Mike Mammarella

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Linux: expose "Use system title bar and borders" preference in options dialog. BUG=19483 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25643

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -2 lines)			Patch
	M	chrome/browser/gtk/options/content_page_gtk.h	View	1	2 chunks	+9 lines, -1 line	0 comments	Download
	M	chrome/browser/gtk/options/content_page_gtk.cc	View	1	5 chunks	+26 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

11 years, 3 months ago (2009-09-08 18:09:53 UTC) #2

lgtm after addressing the one comment

http://codereview.chromium.org/193033/diff/1003/1004
File chrome/browser/gtk/options/content_page_gtk.cc (right):

http://codereview.chromium.org/193033/diff/1003/1004#newcode64
Line 64: if (!pref_name || *pref_name == prefs::kPasswordManagerEnabled) {
I don't get the logic of these conditions, can't we just check pref_name once at
the top and be done with it?

it doesn't make sense to keep checking pref_name and besides it should be
(pref_name && ..) not (!pref_name || ...)

Expand Messages | Collapse Messages