Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1673)

Unified Diff: chrome/browser/cocoa/browser_test_helper.h

Issue 1930002: AutoFill profile shouldn't be saved when cancelled during initial setup. (Closed)
Patch Set: Addressing review comments. Polishing unit test comments. Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/browser_test_helper.h
diff --git a/chrome/browser/cocoa/browser_test_helper.h b/chrome/browser/cocoa/browser_test_helper.h
index b7e3e64d4d5e32ee05cdb7cb478dbc181e18e5c3..8869aadb768f05da3c0c4cfdf571038886d2f3e1 100644
--- a/chrome/browser/cocoa/browser_test_helper.h
+++ b/chrome/browser/cocoa/browser_test_helper.h
@@ -37,7 +37,7 @@ class BrowserTestHelper {
browser_.reset(new Browser(Browser::TYPE_NORMAL, profile_.get()));
}
- ~BrowserTestHelper() {
+ virtual ~BrowserTestHelper() {
// Delete the testing profile on the UI thread. But first release the
// browser, since it may trigger accesses to the profile upon destruction.
browser_.reset(NULL);
@@ -45,7 +45,7 @@ class BrowserTestHelper {
message_loop_.RunAllPending();
}
- TestingProfile* profile() const { return profile_.get(); }
+ virtual TestingProfile* profile() const { return profile_.get(); }
Browser* browser() const { return browser_.get(); }
// Creates the browser window. To close this window call |CloseBrowserWindow|.
« no previous file with comments | « chrome/browser/autofill/personal_data_manager.cc ('k') | chrome/browser/cocoa/preferences_window_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698