Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: src/runtime.cc

Issue 1930: Adapt to new calling convention on ARM. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/macro-assembler-ia32.cc ('k') | src/simulator-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime.cc
===================================================================
--- src/runtime.cc (revision 288)
+++ src/runtime.cc (working copy)
@@ -159,22 +159,9 @@
// literal.
ASSERT(args.length() == 2);
CONVERT_CHECKED(FixedArray, elements, args[0]);
-
-#ifdef USE_OLD_CALLING_CONVENTIONS
- ASSERT(args[1]->IsTheHole());
- // TODO(1332579): Pass in the literals array from the function once
- // the new calling convention is in place on ARM. Currently, we
- // retrieve the array constructor from the global context. This is
- // a security problem since the global object might have been
- // reinitialized and the array constructor from the global context
- // might be from a context that we are not allowed to access.
- JSFunction* constructor =
- JSFunction::cast(Top::context()->global_context()->array_function());
-#else
CONVERT_CHECKED(FixedArray, literals, args[1]);
const int kArrayFunIndex = JSFunction::kLiteralArrayFunctionIndex;
JSFunction* constructor = JSFunction::cast(literals->get(kArrayFunIndex));
-#endif
// Create the JSArray.
Object* object = Heap::AllocateJSObject(constructor);
« no previous file with comments | « src/macro-assembler-ia32.cc ('k') | src/simulator-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698