Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: src/builtins-ia32.cc

Issue 1930: Adapt to new calling convention on ARM. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins-arm.cc ('k') | src/codegen-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins-ia32.cc
===================================================================
--- src/builtins-ia32.cc (revision 288)
+++ src/builtins-ia32.cc (working copy)
@@ -54,8 +54,13 @@
void Builtins::Generate_JSConstructCall(MacroAssembler* masm) {
+ // ----------- S t a t e -------------
+ // -- eax: number of arguments
+ // -- edi: constructor function
+ // -----------------------------------
+
// Enter an internal frame.
- __ EnterFrame(StackFrame::INTERNAL);
+ __ EnterInternalFrame();
// Store a smi-tagged arguments count on the stack.
__ shl(eax, kSmiTagSize);
@@ -296,7 +301,7 @@
// Restore the arguments count and exit the internal frame.
__ bind(&exit);
__ mov(ebx, Operand(esp, kPointerSize)); // get arguments count
- __ ExitFrame(StackFrame::INTERNAL);
+ __ ExitInternalFrame();
// Remove caller arguments from the stack and return.
ASSERT(kSmiTagSize == 1 && kSmiTag == 0);
@@ -318,7 +323,7 @@
__ xor_(esi, Operand(esi)); // clear esi
// Enter an internal frame.
- __ EnterFrame(StackFrame::INTERNAL);
+ __ EnterInternalFrame();
// Load the previous frame pointer (ebx) to access C arguments
__ mov(ebx, Operand(ebp, 0));
@@ -362,7 +367,7 @@
// Exit the JS frame. Notice that this also removes the empty
// context and the function left on the stack by the code
// invocation.
- __ ExitFrame(StackFrame::INTERNAL);
+ __ ExitInternalFrame();
__ ret(1 * kPointerSize); // remove receiver
}
@@ -378,7 +383,7 @@
void Builtins::Generate_FunctionApply(MacroAssembler* masm) {
- __ EnterFrame(StackFrame::INTERNAL);
+ __ EnterInternalFrame();
__ push(Operand(ebp, 4 * kPointerSize)); // push this
__ push(Operand(ebp, 2 * kPointerSize)); // push arguments
@@ -482,7 +487,7 @@
__ mov(edi, Operand(ebp, 4 * kPointerSize));
__ InvokeFunction(edi, actual, CALL_FUNCTION);
- __ ExitFrame(StackFrame::INTERNAL);
+ __ ExitInternalFrame();
__ ret(3 * kPointerSize); // remove this, receiver, and arguments
}
@@ -586,8 +591,7 @@
__ mov(edi, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));
}
- // Mark the adaptor frame as special by overwriting the context slot
- // in the stack with a sentinel.
+ // Call the entry point.
Label return_site;
__ bind(&invoke);
__ call(Operand(edx));
@@ -661,7 +665,7 @@
__ j(less_equal, &done);
__ bind(&call_to_object);
- __ EnterFrame(StackFrame::INTERNAL); // preserves eax, ebx, edi
+ __ EnterInternalFrame(); // preserves eax, ebx, edi
// Store the arguments count on the stack (smi tagged).
ASSERT(kSmiTag == 0);
@@ -678,7 +682,7 @@
__ pop(eax);
__ shr(eax, kSmiTagSize);
- __ ExitFrame(StackFrame::INTERNAL);
+ __ ExitInternalFrame();
__ jmp(&patch_receiver);
// Use the global object from the called function as the receiver.
@@ -747,7 +751,7 @@
__ SaveRegistersToMemory(kJSCallerSaved);
// Enter an internal frame.
- __ EnterFrame(StackFrame::INTERNAL);
+ __ EnterInternalFrame();
// Store the registers containing object pointers on the expression stack to
// make sure that these are correctly updated during GC.
@@ -767,7 +771,7 @@
__ PopRegistersToMemory(pointer_regs);
// Get rid of the internal frame.
- __ ExitFrame(StackFrame::INTERNAL);
+ __ ExitInternalFrame();
// If this call did not replace a call but patched other code then there will
// be an unwanted return address left on the stack. Here we get rid of that.
« no previous file with comments | « src/builtins-arm.cc ('k') | src/codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698