Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1927002: Hiding status area on welcome screen. (Closed)

Created:
10 years, 7 months ago by Nikita (slow)
Modified:
9 years, 7 months ago
Reviewers:
glotov
CC:
chromium-os-reviews_chromium.org, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org, tfarina (gmail-do not use)
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

Hiding status area on welcome screen. Avoid confusion when network is connected. BUG=http://crosbug.com/2322 TEST=Launch for the fist time (or just press Ctrl+Alt+N) and observe that status area is not shown. Status area is shown on other screens. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=46672

Patch Set 1 #

Total comments: 4

Patch Set 2 : nit fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -32 lines) Patch
M chrome/browser/chromeos/login/background_view.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/background_view.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 2 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 5 chunks +50 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nikita (slow)
10 years, 7 months ago (2010-05-05 13:26:17 UTC) #1
glotov
LGTM http://codereview.chromium.org/1927002/diff/1/4 File chrome/browser/chromeos/login/wizard_controller.cc (right): http://codereview.chromium.org/1927002/diff/1/4#newcode272 chrome/browser/chromeos/login/wizard_controller.cc:272: void WizardController::ShowNetworkScreen() { I wish these routines could ...
10 years, 7 months ago (2010-05-05 20:07:38 UTC) #2
Nikita (slow)
http://codereview.chromium.org/1927002/diff/1/4 File chrome/browser/chromeos/login/wizard_controller.cc (right): http://codereview.chromium.org/1927002/diff/1/4#newcode272 chrome/browser/chromeos/login/wizard_controller.cc:272: void WizardController::ShowNetworkScreen() { On 2010/05/05 20:07:38, glotov wrote: > ...
10 years, 7 months ago (2010-05-06 09:54:09 UTC) #3
tfarina (gmail-do not use)
http://codereview.chromium.org/1927002/diff/1/2 File chrome/browser/chromeos/login/background_view.cc (right): http://codereview.chromium.org/1927002/diff/1/2#newcode75 chrome/browser/chromeos/login/background_view.cc:75: void BackgroundView::SetStatusAreaVisible(bool flag) { nit: please, could you rename ...
10 years, 7 months ago (2010-05-06 16:56:03 UTC) #4
Nikita (slow)
10 years, 7 months ago (2010-05-06 17:21:56 UTC) #5
http://codereview.chromium.org/1927002/diff/1/2
File chrome/browser/chromeos/login/background_view.cc (right):

http://codereview.chromium.org/1927002/diff/1/2#newcode75
chrome/browser/chromeos/login/background_view.cc:75: void
BackgroundView::SetStatusAreaVisible(bool flag) {
On 2010/05/06 16:56:03, tfarina wrote:
> nit: please, could you rename this to visible?

Done.

Powered by Google App Engine
This is Rietveld 408576698