Make try job test filter instance specific....

Make try job test filter instance specific.

BUG=17948
TEST=submit test multiple test jobs, some with filters some without


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46593

[vandebo (ex-Chrome), 2010-05-05 00:07:11]

It just occurred to me... will this work with multiple try slaves?  I tested
with just one.

[vandebo (ex-Chrome), 2010-05-05 00:18:44]

On 2010/05/05 00:07:11, vandebo wrote:
> It just occurred to me... will this work with multiple try slaves?  I tested
> with just one.

Never mind. Of course it will properties are build specific.

[M-A Ruel, 2010-05-05 00:49:05]

http://codereview.chromium.org/1924004/diff/1/2
File buildbot/scripts/master/factory/commands.py (right):

http://codereview.chromium.org/1924004/diff/1/2#newcode196
buildbot/scripts/master/factory/commands.py:196:
bStep.setProperty('gtest_filter', None, "Factory")
There's a way to figure out if the property is there so you can not make it
throw an exception. I'd rather not have this try except in there.

[vandebo (ex-Chrome), 2010-05-05 02:46:49]

http://codereview.chromium.org/1924004/diff/1/2
File buildbot/scripts/master/factory/commands.py (right):

http://codereview.chromium.org/1924004/diff/1/2#newcode196
buildbot/scripts/master/factory/commands.py:196:
bStep.setProperty('gtest_filter', None, "Factory")
On 2010/05/05 00:49:05, Marc-Antoine Ruel wrote:
> There's a way to figure out if the property is there so you can not make it
> throw an exception. I'd rather not have this try except in there.

Done.

[M-A Ruel, 2010-05-06 11:52:51]

AppEngine is down so:

line 227:
You need to use optional_arguments.ListProperties() otheriwse it will pass
an empty string argument to the child process and some script don't like
that.

It's used somewhere else you can look how it's used.

lgtm after that.

M-A

Le 4 mai 2010 22:46, <vandebo@chromium.org> a écrit :

>
> http://codereview.chromium.org/1924004/diff/1/2
> File buildbot/scripts/master/factory/commands.py (right):
>
> http://codereview.chromium.org/1924004/diff/1/2#newcode196
> buildbot/scripts/master/factory/commands.py:196:
> bStep.setProperty('gtest_filter', None, "Factory")
> On 2010/05/05 00:49:05, Marc-Antoine Ruel wrote:
>
>> There's a way to figure out if the property is there so you can not
>>
> make it
>
>> throw an exception. I'd rather not have this try except in there.
>>
>
> Done.
>
>
> http://codereview.chromium.org/1924004/show
>

[vandebo (ex-Chrome), 2010-05-06 17:45:11]

On 2010/05/06 11:52:51, Marc-Antoine Ruel wrote:
> line 227:
> You need to use optional_arguments.ListProperties() otheriwse it will pass
> an empty string argument to the child process and some script don't like
> that.

Sorry, 227?  That's not in this change.

> 
> It's used somewhere else you can look how it's used.
> 
> lgtm after that.
> 
> M-A
> 
> Le 4 mai 2010 22:46, <mailto:vandebo@chromium.org> a écrit :
> 
> >
> > http://codereview.chromium.org/1924004/diff/1/2
> > File buildbot/scripts/master/factory/commands.py (right):
> >
> > http://codereview.chromium.org/1924004/diff/1/2#newcode196
> > buildbot/scripts/master/factory/commands.py:196:
> > bStep.setProperty('gtest_filter', None, "Factory")
> > On 2010/05/05 00:49:05, Marc-Antoine Ruel wrote:
> >
> >> There's a way to figure out if the property is there so you can not
> >>
> > make it
> >
> >> throw an exception. I'd rather not have this try except in there.
> >>
> >
> > Done.
> >
> >
> > http://codereview.chromium.org/1924004/show
> >
>

[M-A Ruel, 2010-05-06 17:56:08]

On 2010/05/06 17:45:11, vandebo wrote:
> On 2010/05/06 11:52:51, Marc-Antoine Ruel wrote:
> > line 227:
> > You need to use optional_arguments.ListProperties() otheriwse it will pass
> > an empty string argument to the child process and some script don't like
> > that.
> 
> Sorry, 227?  That's not in this change.

I know, it doesn't mean you don't _need_ to do this so the code continues to
work correctly as I've explained above.

[M-A Ruel, 2010-05-06 17:56:31]

http://codereview.chromium.org/1924004/diff/6001/7001
File buildbot/scripts/master/factory/commands.py (right):

http://codereview.chromium.org/1924004/diff/6001/7001#newcode204
buildbot/scripts/master/factory/commands.py:204: if filter.startswith(("%s:" %
bStep.name)):
remove extra parenthesis:
  if filter.startswith("%s:" % bStep.name):
works too.

[vandebo (ex-Chrome), 2010-05-06 18:37:35]

On 2010/05/06 11:52:51, Marc-Antoine Ruel wrote:
> AppEngine is down so:
> 
> line 227:
> You need to use optional_arguments.ListProperties() otheriwse it will pass
> an empty string argument to the child process and some script don't like
> that.

I thought 227 might be a typo, but I see now.  I fixed it at 251.

> lgtm after that.
> 
> M-A

http://codereview.chromium.org/1924004/diff/6001/7001
File buildbot/scripts/master/factory/commands.py (right):

http://codereview.chromium.org/1924004/diff/6001/7001#newcode204
buildbot/scripts/master/factory/commands.py:204: if filter.startswith(("%s:" %
bStep.name)):
On 2010/05/06 17:56:31, Marc-Antoine Ruel wrote:
> remove extra parenthesis:
>   if filter.startswith("%s:" % bStep.name):
> works too.

Done.

[M-A Ruel, 2010-05-06 18:41:53]

lgtm