Issue 1922: First pass of porting the shared memory unittest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1922: First pass of porting the shared memory unittest. (Closed)

Created:
12 years, 3 months ago by Paul Godavari

Modified:
9 years, 7 months ago

Reviewers:
Amanda Walker

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

First pass of porting the shared memory unittest. We still need to port the underlying SharedMemory machinery, like ShareToProcess, before we can add all the tests in this file to the Mac and linux builds. This change removes the Windows threading dependencies. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2046

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -85 lines)			Patch
	M	base/base.xcodeproj/project.pbxproj	View		4 chunks	+4 lines, -0 lines	0 comments	Download
	M	base/shared_memory_unittest.cc	View		2 chunks	+109 lines, -85 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paul Godavari

This is the same review as before, just moved to a commitable tree. TBR=amanda@chromium.org

12 years, 3 months ago (2008-09-11 00:24:40 UTC) #1

Still LGTM :-).

Expand Messages | Collapse Messages