Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 192068: Remove xmlcatalog and xmllint from the build since we're not actually (Closed)

Created:
11 years, 3 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove xmlcatalog and xmllint from the build since we're not actually using them for anything.

Patch Set 1 #

Patch Set 2 : remove #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -54 lines) Patch
M third_party/libxml/README.chromium View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libxml/libxml.gyp View 1 2 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/libxml/xmlcatalog_dummy.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/libxml/xmllint_dummy.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tony
11 years, 3 months ago (2009-09-10 18:41:52 UTC) #1
Mark Mentovai
LGTM
11 years, 3 months ago (2009-09-10 18:43:43 UTC) #2
Mark Mentovai
You may also svn remove xmldummy_mac.cc.
11 years, 3 months ago (2009-09-10 18:44:08 UTC) #3
Mark Mentovai
You may also remove the line in README.chromium about xmldummy_mac.cc.
11 years, 3 months ago (2009-09-10 18:44:43 UTC) #4
tony
Thanks, done.
11 years, 3 months ago (2009-09-10 18:47:11 UTC) #5
Mark Mentovai
11 years, 3 months ago (2009-09-10 18:48:08 UTC) #6
LGTM still

Powered by Google App Engine
This is Rietveld 408576698