Issue 192064: Hack to make tests work if out is a symlink: see if the current dir is the source root.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 192064: Hack to make tests work if out is a symlink: see if the current dir is the source root. (Closed)

Created:
11 years, 3 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Hack to make tests work if out is a symlink: see if the current dir is the source root. Fix some tests that were manually getting sourcedir from DIR_EXE instead of using DIR_SOURCE_ROOT. BUG=none TEST=rm -r out, ln -s /somedir/out out, run tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25898

Patch Set 1 #

Total comments: 2

Patch Set 2 : use path.DirName().DirName() #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -17 lines)			Patch
M	base/base_paths_linux.cc	View	1	1 chunk	+17 lines, -6 lines	0 comments	Download
M	chrome/test/memory_test/memory_test.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/test/page_cycler/page_cycler_test.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/test/tab_switching/tab_switching_test.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_gtk.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mattm

I got a second drive and symlinked "out" to it so my system isn't useless ...

11 years, 3 months ago (2009-09-10 05:07:04 UTC) #1

Evan Martin

LGTM, something to consider below http://codereview.chromium.org/192064/diff/1/2 File base/base_paths_linux.cc (right): http://codereview.chromium.org/192064/diff/1/2#newcode43 Line 43: path = path.Append(FilePath::kParentDirectory) ...

11 years, 3 months ago (2009-09-10 16:06:50 UTC) #2

mattm

11 years, 3 months ago (2009-09-10 19:31:22 UTC) #3

http://codereview.chromium.org/192064/diff/1/2
File base/base_paths_linux.cc (right):

http://codereview.chromium.org/192064/diff/1/2#newcode43
Line 43: path = path.Append(FilePath::kParentDirectory)
On 2009/09/10 16:06:50, Evan Martin wrote:
> path.DirName().DirName() might be clearer (i've had others tell me this in
> reviews, though i'm not sure i believe it myself)

Hm, yeah.  At least, the resulting path will be cleaner.  I went with that.

Expand Messages | Collapse Messages