Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 192061: Attempt to fix memory leak in some mac tests. (Closed)

Created:
11 years, 3 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
stuartmorgan, dank
CC:
chromium-reviews_googlegroups.com, John Grabowski, Paul Godavari, pam+watch_chromium.org, Ben Goodger (Google), Paweł Hajdan Jr.
Visibility:
Public.

Description

Attempt to fix memory leak in some mac tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25884

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/cocoa/download_util_mac_unittest.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/web_drop_target_unittest.mm View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Stade
A recent clipboard change, http://src.chromium.org/viewvc/chrome?view=rev&revision=25833 seems to have caused some new leaks on mac valgrind ...
11 years, 3 months ago (2009-09-10 04:16:59 UTC) #1
stuartmorgan
LGTM
11 years, 3 months ago (2009-09-10 16:09:02 UTC) #2
dank
11 years, 3 months ago (2009-09-10 16:13:51 UTC) #3
What Stuart said.  I'm not much of a mac dev.

Powered by Google App Engine
This is Rietveld 408576698