Use "GURL::possibly_invalid_spec()" rather than "GURL::spec()", in case the G...

net/url_request/url_request.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request.h"
 
 #include "base/compiler_specific.h"
 #include "base/message_loop.h"
 #include "base/singleton.h"
 #include "base/stats_counters.h"
@@ skipping 83 matching lines @@
   InsertIntoGraveyard(ExtractInfo(node->url_request()));
 }
 
 // static
 const URLRequest::InstanceTracker::RecentRequestInfo
 URLRequest::InstanceTracker::ExtractInfo(URLRequest* url_request) {
   RecentRequestInfo info;
   info.original_url = url_request->original_url();
   info.load_log = url_request->load_log();
 
-  // Paranoia check: truncate really big URLs.
-  if (info.original_url.spec().size() > kMaxGraveyardURLSize) {
-    info.original_url = GURL(url_request->original_url().spec().substr(
-        0, kMaxGraveyardURLSize));
-  }
+  // Paranoia check: truncate |info.original_url| if it is really big.
+  const std::string& spec = info.original_url.possibly_invalid_spec();
+  if (spec.size() > kMaxGraveyardURLSize)
+    info.original_url = GURL(spec.substr(0, kMaxGraveyardURLSize));
   return info;
 }
 
 void URLRequest::InstanceTracker::InsertIntoGraveyard(
     const RecentRequestInfo& info) {
   if (graveyard_.size() < kMaxGraveyardSize) {
     // Still growing to maximum capacity.
     DCHECK_EQ(next_graveyard_index_, graveyard_.size());
     graveyard_.push_back(info);
   } else {
@@ skipping 482 matching lines @@
 URLRequest::UserData* URLRequest::GetUserData(const void* key) const {
   UserDataMap::const_iterator found = user_data_.find(key);
   if (found != user_data_.end())
     return found->second.get();
   return NULL;
 }
 
 void URLRequest::SetUserData(const void* key, UserData* data) {
   user_data_[key] = linked_ptr<UserData>(data);
 }