Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5377)

Unified Diff: chrome/test/in_process_browser_test.cc

Issue 192035: Improves a code block in in_process_browser_test, avoids the use of FilePath:... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/in_process_browser_test.cc
===================================================================
--- chrome/test/in_process_browser_test.cc (revision 25594)
+++ chrome/test/in_process_browser_test.cc (working copy)
@@ -111,14 +111,13 @@
// Explicitly set the path of the exe used for the renderer and plugin,
// otherwise they'll try to use unit_test.exe.
- std::wstring subprocess_path;
+ FilePath subprocess_path;
PathService::Get(base::FILE_EXE, &subprocess_path);
- FilePath fp_subprocess_path = FilePath::FromWStringHack(subprocess_path);
- subprocess_path = fp_subprocess_path.DirName().ToWStringHack();
- file_util::AppendToPath(&subprocess_path,
- chrome::kBrowserProcessExecutablePath);
+ subprocess_path = subprocess_path.DirName();
+ subprocess_path = subprocess_path.AppendASCII(WideToASCII(
+ chrome::kBrowserProcessExecutablePath));
command_line->AppendSwitchWithValue(switches::kBrowserSubprocessPath,
- subprocess_path);
+ subprocess_path.ToWStringHack());
// Enable warning level logging so that we can see when bad stuff happens.
command_line->AppendSwitch(switches::kEnableLogging);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698