Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 192033: Final tweaks to download items on OS X. (Closed)

Created:
11 years, 3 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Final tweaks to download item look on OS X. It now looks pretty much like on windows and linux, but is drawn nearly completely with vectors. Also fix the SkColor->NSColor conversion in the mac theme provider. Also let status bubble text color be influenced by current theme. BUG=18902, 18438 TEST=Download items now look like on windows. Color of the main download item text should change with the theme. Also, the status bubble text now adapts to the theme, and themes that specify text colors can now successfully change the color of e.g. the text in tabs. Also check that the status text ("104.0/110 MB, 1 h 45 secs left") is elided at the right when it's too long. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25616

Patch Set 1 #

Patch Set 2 : Elide status text #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -25 lines) Patch
M chrome/app/nibs/DownloadItem.xib View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/browser_theme_provider_mac.mm View 1 chunk +6 lines, -4 lines 1 comment Download
M chrome/browser/cocoa/download_item_cell.mm View 1 9 chunks +62 lines, -17 lines 0 comments Download
M chrome/browser/cocoa/download_shelf_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/status_bubble_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
Avi, since this is theme-related, I'm sending this to you. I've put screenshots of the ...
11 years, 3 months ago (2009-09-05 21:51:46 UTC) #1
Nico
*too high
11 years, 3 months ago (2009-09-05 21:52:31 UTC) #2
Avi (use Gerrit)
11 years, 3 months ago (2009-09-08 14:47:43 UTC) #3
LG

http://codereview.chromium.org/192033/diff/3002/3004
File chrome/browser/browser_theme_provider_mac.mm (right):

http://codereview.chromium.org/192033/diff/3002/3004#newcode87
Line 87: alpha:SkColorGetA(sk_color)/255.0];
Yes, I am appropriately embarrassed. :)

Powered by Google App Engine
This is Rietveld 408576698