Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2314)

Unified Diff: chrome/browser/in_process_webkit/webkit_thread.cc

Issue 192003: Refactor DOM Storage to pave the way for events and locking. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/in_process_webkit/webkit_thread.h ('k') | chrome/chrome.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/in_process_webkit/webkit_thread.cc
===================================================================
--- chrome/browser/in_process_webkit/webkit_thread.cc (revision 25608)
+++ chrome/browser/in_process_webkit/webkit_thread.cc (working copy)
@@ -27,8 +27,6 @@
DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));
DCHECK(io_message_loop_);
- // TODO(jorlow): Start flushing LocalStorage?
-
AutoLock lock(io_message_loop_lock_);
io_message_loop_ = NULL;
}
@@ -48,24 +46,23 @@
}
WebKitThread::InternalWebKitThread::InternalWebKitThread()
- : ChromeThread(ChromeThread::WEBKIT),
- webkit_client_(NULL) {
+ : ChromeThread(ChromeThread::WEBKIT) {
}
+WebKitThread::InternalWebKitThread::~InternalWebKitThread() {
+}
+
void WebKitThread::InternalWebKitThread::Init() {
- DCHECK(!webkit_client_);
- webkit_client_ = new BrowserWebKitClientImpl;
- DCHECK(webkit_client_);
- WebKit::initialize(webkit_client_);
+ DCHECK(!webkit_client_.get());
+ webkit_client_.reset(new BrowserWebKitClientImpl);
+ WebKit::initialize(webkit_client_.get());
// If possible, post initialization tasks to this thread (rather than doing
// them now) so we don't block the IO thread any longer than we have to.
}
void WebKitThread::InternalWebKitThread::CleanUp() {
- // TODO(jorlow): Block on LocalStorage being 100% shut down.
- DCHECK(webkit_client_);
+ DCHECK(webkit_client_.get());
WebKit::shutdown();
- delete webkit_client_;
}
MessageLoop* WebKitThread::InitializeThread() {
« no previous file with comments | « chrome/browser/in_process_webkit/webkit_thread.h ('k') | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698