Issue 1918002: Add some comments to the ia32 code generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1918002: Add some comments to the ia32 code generator (Closed)

Created:
10 years, 7 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add some comments to the ia32 code generator Committed: http://code.google.com/p/v8/source/detail?r=4586

Patch Set 2 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -12 lines)			Patch
	M	src/arm/codegen-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/ia32/codegen-ia32.cc	View	1	11 chunks	+64 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/1918002/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1918002/diff/1/2#newcode5429 src/ia32/codegen-ia32.cc:5429: // Initialization block consists of assignments on the ...

10 years, 7 months ago (2010-05-04 20:53:03 UTC) #2

Søren Thygesen Gjesse

10 years, 7 months ago (2010-05-05 06:48:49 UTC) #3

http://codereview.chromium.org/1918002/diff/1/2
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/1918002/diff/1/2#newcode5429
src/ia32/codegen-ia32.cc:5429: // Initialization block consists of assignments
on the form expr.x = ..., so
On 2010/05/04 20:53:03, Erik Corry wrote:
> on the form -> of the form

Done.

Expand Messages | Collapse Messages

Issue 1918002: Add some comments to the ia32 code generator (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages