Issue 1917007: Test that serializing a document with an iframe that was downloaded doesn't c...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1917007: Test that serializing a document with an iframe that was downloaded doesn't c... (Closed)

Created:
10 years, 7 months ago by Nate Chapin

Modified:
9 years, 5 months ago

Reviewers:
abarth-chromium

CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Test that serializing a document with an iframe that was downloaded doesn't cause a renderer crash. BUG=42212 TEST=DomSerializerTests.SerializeDocumentWithDownloadedIFrame Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47054

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, --1 lines)			Patch
A	webkit/data/dom_serializer/dummy.exe	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	webkit/data/dom_serializer/iframe-src-is-exe.htm	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	webkit/glue/dom_serializer_unittest.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nate Chapin

Depends on https://bugs.webkit.org/show_bug.cgi?id=38543

10 years, 7 months ago (2010-05-05 16:22:19 UTC) #1

abarth-chromium

10 years, 7 months ago (2010-05-05 16:40:14 UTC) #2

LGTM.

It would be better to have the test in the same repository as the code with the
bug so that the WebKit gardener can catch regressions upstream, but I'll never
say no to a test.  :)

Expand Messages | Collapse Messages