Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: chrome/browser/bookmark_bar_context_menu_controller_test.cc

Issue 1912: Renames BoomarkBarModel to BookmarkModel. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bookmark_bar_context_menu_controller.h" 5 #include "chrome/browser/bookmark_bar_context_menu_controller.h"
6 #include "chrome/browser/bookmarks/bookmark_bar_model.h" 6 #include "chrome/browser/bookmarks/bookmark_model.h"
7 #include "chrome/browser/profile.h" 7 #include "chrome/browser/profile.h"
8 #include "chrome/browser/views/bookmark_bar_view.h" 8 #include "chrome/browser/views/bookmark_bar_view.h"
9 #include "chrome/common/pref_names.h" 9 #include "chrome/common/pref_names.h"
10 #include "chrome/common/pref_service.h" 10 #include "chrome/common/pref_service.h"
11 #include "chrome/browser/page_navigator.h" 11 #include "chrome/browser/page_navigator.h"
12 #include "chrome/test/testing_profile.h" 12 #include "chrome/test/testing_profile.h"
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 14
15 namespace { 15 namespace {
16 16
(...skipping 15 matching lines...) Expand all
32 public: 32 public:
33 BookmarkBarContextMenuControllerTest() 33 BookmarkBarContextMenuControllerTest()
34 : bb_view_(NULL), model_(NULL) { 34 : bb_view_(NULL), model_(NULL) {
35 } 35 }
36 36
37 virtual void SetUp() { 37 virtual void SetUp() {
38 BookmarkBarView::testing_ = true; 38 BookmarkBarView::testing_ = true;
39 39
40 profile_.reset(new TestingProfile()); 40 profile_.reset(new TestingProfile());
41 profile_->set_has_history_service(true); 41 profile_->set_has_history_service(true);
42 profile_->CreateBookmarkBarModel(true); 42 profile_->CreateBookmarkModel(true);
43 43
44 model_ = profile_->GetBookmarkBarModel(); 44 model_ = profile_->GetBookmarkModel();
45 45
46 bb_view_.reset(new BookmarkBarView(profile_.get(), NULL)); 46 bb_view_.reset(new BookmarkBarView(profile_.get(), NULL));
47 bb_view_->SetPageNavigator(&navigator_); 47 bb_view_->SetPageNavigator(&navigator_);
48 48
49 AddTestData(); 49 AddTestData();
50 } 50 }
51 51
52 virtual void TearDown() { 52 virtual void TearDown() {
53 BookmarkBarView::testing_ = false; 53 BookmarkBarView::testing_ = false;
54 54
55 // Flush the message loop to make Purify happy. 55 // Flush the message loop to make Purify happy.
56 message_loop_.RunAllPending(); 56 message_loop_.RunAllPending();
57 } 57 }
58 58
59 protected: 59 protected:
60 MessageLoopForUI message_loop_; 60 MessageLoopForUI message_loop_;
61 scoped_ptr<TestingProfile> profile_; 61 scoped_ptr<TestingProfile> profile_;
62 BookmarkBarModel* model_; 62 BookmarkModel* model_;
63 scoped_ptr<BookmarkBarView> bb_view_; 63 scoped_ptr<BookmarkBarView> bb_view_;
64 TestingPageNavigator navigator_; 64 TestingPageNavigator navigator_;
65 65
66 private: 66 private:
67 // Creates the following structure: 67 // Creates the following structure:
68 // a 68 // a
69 // F1 69 // F1
70 // f1a 70 // f1a
71 // F11 71 // F11
72 // f11a 72 // f11a
73 // F2 73 // F2
74 void AddTestData() { 74 void AddTestData() {
75 std::string test_base = "file:///c:/tmp/"; 75 std::string test_base = "file:///c:/tmp/";
76 76
77 model_->AddURL(model_->GetBookmarkBarNode(), 0, L"a", 77 model_->AddURL(model_->GetBookmarkBarNode(), 0, L"a",
78 GURL(test_base + "a")); 78 GURL(test_base + "a"));
79 BookmarkBarNode* f1 = 79 BookmarkNode* f1 =
80 model_->AddGroup(model_->GetBookmarkBarNode(), 1, L"F1"); 80 model_->AddGroup(model_->GetBookmarkBarNode(), 1, L"F1");
81 model_->AddURL(f1, 0, L"f1a", GURL(test_base + "f1a")); 81 model_->AddURL(f1, 0, L"f1a", GURL(test_base + "f1a"));
82 BookmarkBarNode* f11 = model_->AddGroup(f1, 1, L"F11"); 82 BookmarkNode* f11 = model_->AddGroup(f1, 1, L"F11");
83 model_->AddURL(f11, 0, L"f11a", GURL(test_base + "f11a")); 83 model_->AddURL(f11, 0, L"f11a", GURL(test_base + "f11a"));
84 model_->AddGroup(model_->GetBookmarkBarNode(), 2, L"F2"); 84 model_->AddGroup(model_->GetBookmarkBarNode(), 2, L"F2");
85 } 85 }
86 }; 86 };
87 87
88 // Tests Deleting from the menu. 88 // Tests Deleting from the menu.
89 TEST_F(BookmarkBarContextMenuControllerTest, DeleteURL) { 89 TEST_F(BookmarkBarContextMenuControllerTest, DeleteURL) {
90 BookmarkBarContextMenuController controller( 90 BookmarkBarContextMenuController controller(
91 bb_view_.get(), model_->GetBookmarkBarNode()->GetChild(0)); 91 bb_view_.get(), model_->GetBookmarkBarNode()->GetChild(0));
92 GURL url = model_->GetBookmarkBarNode()->GetChild(0)->GetURL(); 92 GURL url = model_->GetBookmarkBarNode()->GetChild(0)->GetURL();
(...skipping 16 matching lines...) Expand all
109 // Open it. 109 // Open it.
110 controller.ExecuteCommand( 110 controller.ExecuteCommand(
111 BookmarkBarContextMenuController::open_bookmark_id); 111 BookmarkBarContextMenuController::open_bookmark_id);
112 // Should have navigated to it. 112 // Should have navigated to it.
113 ASSERT_EQ(1, navigator_.urls_.size()); 113 ASSERT_EQ(1, navigator_.urls_.size());
114 ASSERT_TRUE(url == navigator_.urls_[0]); 114 ASSERT_TRUE(url == navigator_.urls_[0]);
115 } 115 }
116 116
117 // Tests open all on a folder with a couple of bookmarks. 117 // Tests open all on a folder with a couple of bookmarks.
118 TEST_F(BookmarkBarContextMenuControllerTest, OpenAll) { 118 TEST_F(BookmarkBarContextMenuControllerTest, OpenAll) {
119 BookmarkBarNode* folder = model_->GetBookmarkBarNode()->GetChild(1); 119 BookmarkNode* folder = model_->GetBookmarkBarNode()->GetChild(1);
120 BookmarkBarContextMenuController controller(bb_view_.get(), folder); 120 BookmarkBarContextMenuController controller(bb_view_.get(), folder);
121 ASSERT_TRUE(controller.IsCommandEnabled( 121 ASSERT_TRUE(controller.IsCommandEnabled(
122 BookmarkBarContextMenuController::open_all_bookmarks_id)); 122 BookmarkBarContextMenuController::open_all_bookmarks_id));
123 ASSERT_TRUE(controller.IsCommandEnabled( 123 ASSERT_TRUE(controller.IsCommandEnabled(
124 BookmarkBarContextMenuController::open_all_bookmarks_in_new_window_id)); 124 BookmarkBarContextMenuController::open_all_bookmarks_in_new_window_id));
125 // Open it. 125 // Open it.
126 controller.ExecuteCommand( 126 controller.ExecuteCommand(
127 BookmarkBarContextMenuController::open_all_bookmarks_id); 127 BookmarkBarContextMenuController::open_all_bookmarks_id);
128 // Should have navigated to F1's children. 128 // Should have navigated to F1's children.
129 ASSERT_EQ(2, navigator_.urls_.size()); 129 ASSERT_EQ(2, navigator_.urls_.size());
130 ASSERT_TRUE(folder->GetChild(0)->GetURL() == navigator_.urls_[0]); 130 ASSERT_TRUE(folder->GetChild(0)->GetURL() == navigator_.urls_[0]);
131 ASSERT_TRUE(folder->GetChild(1)->GetChild(0)->GetURL() == 131 ASSERT_TRUE(folder->GetChild(1)->GetChild(0)->GetURL() ==
132 navigator_.urls_[1]); 132 navigator_.urls_[1]);
133 } 133 }
134 134
135 // Tests that menus are appropriately disabled for empty folders. 135 // Tests that menus are appropriately disabled for empty folders.
136 TEST_F(BookmarkBarContextMenuControllerTest, DisableForEmptyFolder) { 136 TEST_F(BookmarkBarContextMenuControllerTest, DisableForEmptyFolder) {
137 BookmarkBarNode* folder = model_->GetBookmarkBarNode()->GetChild(2); 137 BookmarkNode* folder = model_->GetBookmarkBarNode()->GetChild(2);
138 BookmarkBarContextMenuController controller(bb_view_.get(), folder); 138 BookmarkBarContextMenuController controller(bb_view_.get(), folder);
139 EXPECT_FALSE(controller.IsCommandEnabled( 139 EXPECT_FALSE(controller.IsCommandEnabled(
140 BookmarkBarContextMenuController::open_all_bookmarks_id)); 140 BookmarkBarContextMenuController::open_all_bookmarks_id));
141 EXPECT_FALSE(controller.IsCommandEnabled( 141 EXPECT_FALSE(controller.IsCommandEnabled(
142 BookmarkBarContextMenuController::open_all_bookmarks_in_new_window_id)); 142 BookmarkBarContextMenuController::open_all_bookmarks_in_new_window_id));
143 } 143 }
144 144
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698