Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Issue 1912: Renames BoomarkBarModel to BookmarkModel. (Closed)

Created:
12 years, 3 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
jcampan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Renames BoomarkBarModel to BookmarkModel. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2057

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+791 lines, -2688 lines) Patch
M chrome/SConscript.unit_tests View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/history_contents_provider.h View 3 chunks +5 lines, -6 lines 1 comment Download
M chrome/browser/autocomplete/history_contents_provider.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/autocomplete/history_contents_provider_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmark_bar_context_menu_controller.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/bookmark_bar_context_menu_controller.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/bookmark_bar_context_menu_controller_test.cc View 6 chunks +8 lines, -8 lines 0 comments Download
D chrome/browser/bookmarks/bookmark_bar_model.h View 1 chunk +0 lines, -435 lines 0 comments Download
D chrome/browser/bookmarks/bookmark_bar_model.cc View 1 chunk +0 lines, -694 lines 0 comments Download
D chrome/browser/bookmarks/bookmark_bar_model_unittest.cc View 1 chunk +0 lines, -721 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_codec.h View 3 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_codec.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_drag_data.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_drag_data.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_drag_data_unittest.cc View 5 chunks +14 lines, -14 lines 0 comments Download
A + chrome/browser/bookmarks/bookmark_model.h View 12 chunks +92 lines, -94 lines 0 comments Download
A + chrome/browser/bookmarks/bookmark_model.cc View 37 chunks +96 lines, -97 lines 0 comments Download
A + chrome/browser/bookmarks/bookmark_model_unittest.cc View 32 chunks +109 lines, -112 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_storage.h View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_storage.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser.vcproj View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.h View 3 chunks +16 lines, -16 lines 1 comment Download
M chrome/browser/dom_ui/new_tab_ui.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/history/expire_history_backend_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/history/starred_url_database.cc View 1 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/history_model.h View 1 chunk +2 lines, -2 lines 1 comment Download
M chrome/browser/history_model.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ie_importer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer.h View 4 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/importer.cc View 6 chunks +17 lines, -19 lines 0 comments Download
M chrome/browser/importer_unittest.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/metrics_service.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/metrics_service.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/profile.h View 1 4 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/profile.cc View 1 5 chunks +9 lines, -17 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.h View 11 chunks +37 lines, -39 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 40 chunks +73 lines, -77 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view_test.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/views/bookmark_bubble_view.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/views/bookmark_bubble_view.cc View 8 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/views/bookmark_editor_view.h View 8 chunks +41 lines, -43 lines 1 comment Download
M chrome/browser/views/bookmark_editor_view.cc View 16 chunks +43 lines, -43 lines 0 comments Download
M chrome/browser/views/bookmark_editor_view_unittest.cc View 13 chunks +22 lines, -28 lines 0 comments Download
M chrome/browser/views/toolbar_star_toggle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_contents.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/testing_profile.h View 1 4 chunks +8 lines, -11 lines 1 comment Download
M chrome/test/testing_profile.cc View 3 chunks +18 lines, -18 lines 0 comments Download
M chrome/test/unit/unittests.vcproj View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
12 years, 3 months ago (2008-09-10 22:32:20 UTC) #1
jcampan
12 years, 3 months ago (2008-09-10 23:01:24 UTC) #2
LGTM

Nits below

http://codereview.chromium.org/1912/diff/401/67
File chrome/browser/autocomplete/history_contents_provider.h (right):

http://codereview.chromium.org/1912/diff/401/67#newcode5
Line 5: #ifndef CHROME_BROWSER_AUTOCOMPLETE_HISTORY_CONTENTS_PROVIDER_H__
Since you were changing the double __ to a single _ in another h file, may be
you could do it there as well?

http://codereview.chromium.org/1912/diff/401/91
File chrome/browser/dom_ui/new_tab_ui.h (right):

http://codereview.chromium.org/1912/diff/401/91#newcode6
Line 6: #define CHROME_BROWSER_DOM_UI_NEW_TAB_UI_H__
Since you were changing the double __ to a single _ in another h file, may be
you could do it there as well?

http://codereview.chromium.org/1912/diff/401/84
File chrome/browser/history_model.h (right):

http://codereview.chromium.org/1912/diff/401/84#newcode10
Line 10: #define CHROME_BROWSER_HISTORY_MODEL_H__
Since you were changing the double __ to a single _ in another h file, may be
you could do it there as well?

http://codereview.chromium.org/1912/diff/401/78
File chrome/browser/views/bookmark_editor_view.h (right):

http://codereview.chromium.org/1912/diff/401/78#newcode143
Line 143: int new_index);
Indent is off.

http://codereview.chromium.org/1912/diff/401/58
File chrome/test/testing_profile.h (right):

http://codereview.chromium.org/1912/diff/401/58#newcode5
Line 5: #ifndef CHROME_TEST_TESTING_PROFILE_H__
Since you were changing the double __ to a single _ in some other h file, may be
you could do it here as well?

Powered by Google App Engine
This is Rietveld 408576698