Issue 191002: Change directory to repository root before running CheckSvnModifiedDirectorie...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 191002: Change directory to repository root before running CheckSvnModifiedDirectorie... (Closed)

Created:
11 years, 3 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com, TVL

Base URL:
svn://chrome-svn/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Change directory to repository root before running CheckSvnModifiedDirectories. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25270

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
	M	presubmit_support.py	View	1	1 chunk	+16 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

wdyt? http://codereview.chromium.org/191002/diff/1/3 File presubmit_support.py (right): http://codereview.chromium.org/191002/diff/1/3#newcode699 Line 699: changelists = gcl.GetModifiedFiles() You should fix this ...

11 years, 3 months ago (2009-09-02 14:53:13 UTC) #2

much better, lgtm

Expand Messages | Collapse Messages

Issue 191002: Change directory to repository root before running CheckSvnModifiedDirectorie... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages