Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2532)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/SConscript.v8

Issue 19041: Allow "hammer Hammer SHARED=1" to build cleanly. (Closed)
Patch Set: remove media Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/SConscript.main ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/SConscript.v8
diff --git a/build/SConscript.v8 b/build/SConscript.v8
index ec0bd835c052a04a0fd70e512a0c6e4a9e9f1fe7..fc7fa818d69758a76c395e4284b9d63c1e4e20be 100644
--- a/build/SConscript.v8
+++ b/build/SConscript.v8
@@ -15,6 +15,10 @@ mode = 'release'
if env['TARGET_DEBUG']:
mode = 'debug'
+# Don't build V8 as a shared object because the v8 scons file doesn't support
+# it.
+env.Replace(COMPONENT_STATIC=True)
+
env = env.Clone(
V8_MODE = mode,
V8_MODE_DIR = '$V8_DIR/obj/$V8_MODE',
« no previous file with comments | « build/SConscript.main ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698