Issue 19041: Allow "hammer Hammer SHARED=1" to build cleanly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19041: Allow "hammer Hammer SHARED=1" to build cleanly. (Closed)

Created:
11 years, 11 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Allow "hammer Hammer SHARED=1" to build cleanly. This change is just disabling the targets that don't currently work. This is needed for the debug linux webkit builder that is coming online real soon now.

Patch Set 1 #

Total comments: 1

Patch Set 2 : comments #

Patch Set 3 : remove media #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	build/SConscript.main	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
	M	build/SConscript.v8	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

http://codereview.chromium.org/19041/diff/1/2 File build/SConscript.main (right): http://codereview.chromium.org/19041/diff/1/2#newcode544 Line 544: # so filter out Chrome. Add TODO(port)? Or ...

11 years, 11 months ago (2009-01-27 22:27:20 UTC) #2

tony

I added a print about filtering out chrome and updated SConscript.v8 to always build static. ...

11 years, 11 months ago (2009-01-27 22:45:55 UTC) #3

Lei Zhang

11 years, 11 months ago (2009-01-27 23:16:21 UTC) #5

On 2009/01/27 22:48:53, Evan Martin wrote:
> LGTM

LGTM to patch set 3, with media/ removed. I'll try to make media/ work.

Expand Messages | Collapse Messages