Fix -[NSString isValidURI].

Fix -[NSString isValidURI].

Use GURL for validation instead of NSURL. NSURL is extremely liberal
with what it considers a valid URI, since it also uses RFC 1808 to
parse.

BUG=43100
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46318

[dcheng, 2010-05-03 23:51:44]

Not sure who's an appropriate reviewer for this change. Either of you mind
taking a look?

[Mark Mentovai, 2010-05-04 01:20:44]

LGTM with these changes. Either of us are appropriate reviewers for this.

http://codereview.chromium.org/1904001/diff/2001/3002
File third_party/mozilla/NSString+Utils.mm (right):

http://codereview.chromium.org/1904001/diff/2001/3002#newcode1
third_party/mozilla/NSString+Utils.mm:1: /* ***** BEGIN LICENSE BLOCK *****
I don’t see a “D” for the old .m version of this file - you should “svn remove”
the original and make sure the remove is part of this change.

http://codereview.chromium.org/1904001/diff/2001/3003
File third_party/mozilla/README.chromium (right):

http://codereview.chromium.org/1904001/diff/2001/3003#newcode17
third_party/mozilla/README.chromium:17: NSStrings+Utils.m was renamed and
modified to use GURL for validation in
Say what it was renamed to.

http://codereview.chromium.org/1904001/diff/2001/3003#newcode18
third_party/mozilla/README.chromium:18: [NSString isValidURI].
Use proper Objective-C name formatting. This one should have a dash to indicate
it’s an instance method: -[NSString isValidURI].

Same applies to the change description.

[dcheng, 2010-05-04 01:28:08]

http://codereview.chromium.org/1904001/diff/2001/3002
File third_party/mozilla/NSString+Utils.mm (right):

http://codereview.chromium.org/1904001/diff/2001/3002#newcode1
third_party/mozilla/NSString+Utils.mm:1: /* ***** BEGIN LICENSE BLOCK *****
On 2010/05/04 01:20:45, Mark Mentovai wrote:
> I don’t see a “D” for the old .m version of this file - you should “svn
remove”
> the original and make sure the remove is part of this change.

I'm using git. git knows about the rename, and the wiki page claims that the
correct magic will happen with git cl dcommit if git knows about the rename.

http://codereview.chromium.org/1904001/diff/2001/3003
File third_party/mozilla/README.chromium (right):

http://codereview.chromium.org/1904001/diff/2001/3003#newcode17
third_party/mozilla/README.chromium:17: NSStrings+Utils.m was renamed and
modified to use GURL for validation in
On 2010/05/04 01:20:45, Mark Mentovai wrote:
> Say what it was renamed to.

Done.

http://codereview.chromium.org/1904001/diff/2001/3003#newcode18
third_party/mozilla/README.chromium:18: [NSString isValidURI].
On 2010/05/04 01:20:45, Mark Mentovai wrote:
> Use proper Objective-C name formatting. This one should have a dash to
indicate
> it’s an instance method: -[NSString isValidURI].
> 
> Same applies to the change description.

Done.

[Mark Mentovai, 2010-05-04 01:32:57]

LGTM.

Be sure to watch that the file is indeed deleted after your git commit, and fix
it up or holler if it’s not.

Thanks for the quick attention on this!