Add portable keyboard codes

Add portable keyboard codes

[Paweł Hajdan Jr., 2009-01-27 17:21:19]

When porting link.cc I encountered one issue: VK_ constants which are
Windows-specific.

This changeset adds portable keycode definitions similar to webkit ones.

What do you think?

[Mark Mentovai, 2009-01-27 17:23:01]

+tony, I think he's been down this road before.

[Evan Martin, 2009-01-27 18:01:11]

Where are these needed?  I think in any place we're accepting WIndows keycodes
in the UI we'll need to do more careful cross-platform work.  The main reason we
needed Windows keycodes at the WebKit layer is that the effective API of
javascript on the web (due to IE dominance) is Windows keycodes.

[Paweł Hajdan Jr., 2009-01-27 18:13:53]

On 2009/01/27 18:01:11, Evan Martin wrote:
> Where are these needed?

For example in chrome/views/link.cc:

bool Link::OnKeyPressed(const KeyEvent& e) {
  if ((e.GetCharacter() == VK_SPACE) || (e.GetCharacter() == VK_RETURN)) {

If there's better way to do it, then it's great.

[tony, 2009-01-27 18:35:20]

I think we still need some keyboard abstraction so we can refer to things like
the Enter key.  I think it would be nice if we could put this into base so we
can also use this in test_shell (specifically, event_sending_controller
shouldn't include the keyboardcodes.h from webkit).

On 2009/01/27 18:01:11, Evan Martin wrote:
> Where are these needed?  I think in any place we're accepting WIndows keycodes
> in the UI we'll need to do more careful cross-platform work.  The main reason
we
> needed Windows keycodes at the WebKit layer is that the effective API of
> javascript on the web (due to IE dominance) is Windows keycodes.

[Paweł Hajdan Jr., 2009-01-27 18:54:09]

On 2009/01/27 18:35:20, tony wrote:
> I think we still need some keyboard abstraction so
> we can refer to things like the Enter key.

Hmm... do you have some idea? Isn't it VKEY_RETURN?

> I think it would be nice if we could put this into base so we can
> also use this in test_shell.

Done.

[tony, 2009-01-27 19:17:46]

I don't have a strong opinion of keeping the Windows names (VK_*).  I'm not sure
it helps much if we're going to put it in a namespace, so this is fine with me. 
Ben can chime in if he wants to keep the VK_* names.

LGTM.

http://codereview.chromium.org/19021/diff/206/9
File base/keyboard_codes_posix.h (right):

http://codereview.chromium.org/19021/diff/206/9#newcode34
Line 34: namespace views {
namespace base?

http://codereview.chromium.org/19021/diff/206/10
File base/keyboard_codes_win.h (right):

http://codereview.chromium.org/19021/diff/206/10#newcode10
Line 10: namespace views {
namespace base

[Paweł Hajdan Jr., 2009-01-28 15:47:54]

On 2009/01/27 19:17:46, tony wrote:
> LGTM.

I updated vcproj and scons files. Can someone look and check it?

Mark: I was thinking about sending e-mail to chromium-dev like "if you want to
use VK_ constant, use constant from base/keyboard_codes.h". Is is a good idea?
That would be more noticable than any comments in these new files because to
read them, you have to notice the file first.

[Mark Mentovai, 2009-01-28 16:41:16]

Project file changes LGTM.

[Evan Martin, 2009-01-28 17:21:21]

Urgh, I hate that we're going to need to port native->Windows events twice.  We
really need to figure out what we're doing with views on Linux.  I will write a
mail to chromium-dev about what I've been thinking about.

[Steve Block, 2012-03-20 13:38:59]

http://codereview.chromium.org/19021/diff/401/base/keyboard_codes_posix.h
File base/keyboard_codes_posix.h (right):

http://codereview.chromium.org/19021/diff/401/base/keyboard_codes_posix.h#new...
base/keyboard_codes_posix.h:6: * Copyright (C) 2006 Michael Emmel
mike.emmel@gmail.com. All rights reserved.
Hi Pawel, I know this an old change, but I'm looking into third-party licenses
and wondered if you know where this code is copied from? It looks like a WebKit
license, but I can't find this exact code in WebKit.

Thanks for your help,
Steve

[Mark Mentovai, 2012-03-20 14:16:04]

This file has a history of hopping between repositories. It originally came from
WebKit, but you won’t find it in their current repository. You’ve got to dig
into the history.

This file was removed from WebKit at r56704, having been checked in at r39903:

http://trac.webkit.org/changeset/56704
http://trac.webkit.org/log/trunk/WebCore/platform/chromium/KeyboardCodesPosix...

Previously, it was in the Chromium repository, removed at Chromium r7405, and
checked in at r3840.

http://src.chromium.org/viewvc/chrome?view=rev&revision=7405
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/port/platform/chromium...

Before that, it came from WebKit, removed at WebKit r56704 (when the Chromium
file was also removed). Two earlier files were merged at r44291. The GDK/GTK
file was moved at r25703, and checked in at r15124. The Qt file was merged at
r44290 and checked in at r15944 (but was probably based on the GDK/GTK file).

Merged:
http://trac.webkit.org/changeset/56704
http://trac.webkit.org/log/trunk/WebCore/platform/KeyboardCodes.h?rev=56703

GDK/GTK:
http://trac.webkit.org/log/trunk/WebCore/platform/gtk/KeyboardCodes.h?rev=44290
http://trac.webkit.org/changeset/25703
http://trac.webkit.org/log/trunk/WebCore/platform/gdk/KeyboardCodes.h?rev=25702

Qt:
http://trac.webkit.org/log/trunk/WebCore/platform/qt/KeyboardCodes.h?rev=44290

[Steve Block, 2012-03-21 11:46:04]

Got it, thanks!