Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 19013: Further minify non-visible JavaScript. (Closed)

Created:
11 years, 11 months ago by Dean McNamee
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Further minify non-visible JavaScript. This imports a Python version of Douglas Crockford's JSMin. JavaScript files can annotate that they want to be run through the minifier. Currently debug and mirror are minified. This results in ~12k savings on the final binary size.

Patch Set 1 #

Patch Set 2 : Add to LICENSE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -2 lines) Patch
M LICENSE View 1 chunk +4 lines, -0 lines 0 comments Download
M src/debug-delay.js View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mirror-delay.js View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/js2c.py View 3 chunks +9 lines, -2 lines 0 comments Download
A tools/jsmin.py View 1 chunk +218 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dean McNamee
The way I wrote the code is kinda ugly. Feel free to give me input, ...
11 years, 11 months ago (2009-01-27 13:33:20 UTC) #1
Christian Plesner Hansen
You should add an entry for jsmin in the top-level LICENSE file. Otherwise lgtm. I'm ...
11 years, 11 months ago (2009-01-27 14:07:09 UTC) #2
Dean McNamee
I don't see the point of leaving non-visible code not-minified, even on desktop systems. It's ...
11 years, 11 months ago (2009-01-27 14:15:45 UTC) #3
Mads Ager (chromium)
11 years, 11 months ago (2009-01-27 16:28:37 UTC) #4
LGTM as well.

Powered by Google App Engine
This is Rietveld 408576698