Issue 19012: Strip /* */ style comments in js2c. Saves ~17k of binary size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19012: Strip /* */ style comments in js2c. Saves ~17k of binary size. (Closed)

Created:
11 years, 10 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Strip /* */ style comments in js2c. Saves ~17k of binary size.

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tools/js2c.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Dean McNamee

Hopefully my sloppy regex skills don't destroy the world.

11 years, 10 months ago (2009-01-27 12:44:08 UTC) #1

Søren Thygesen Gjesse

11 years, 10 months ago (2009-01-27 16:00:15 UTC) #3

On 2009/01/27 12:56:31, Mads Ager wrote:
> LGTM

LGTM