Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/hash_tables.h

Issue 190003: Add some comments to base. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/scoped_ptr.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/hash_tables.h
===================================================================
--- base/hash_tables.h (revision 25142)
+++ base/hash_tables.h (working copy)
@@ -11,6 +11,12 @@
// base::hash_map<int> my_map;
// base::hash_set<int> my_set;
//
+// NOTE: It is an explicit non-goal of this class to provide a generic hash
+// function for pointers. If you to hash a pointers to a particular class,
darin (slow to review) 2009/09/03 05:23:11 nit: "If you _want_ to hash pointers..."
+// please define the template specialization elsewhere (for example, in its
+// header file) and keep it specific to just pointers to that class. This is
+// because identity hashes are not desirable for all types that might show up
+// in containers as pointers.
#ifndef BASE_HASH_TABLES_H_
#define BASE_HASH_TABLES_H_
« no previous file with comments | « no previous file | base/scoped_ptr.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698