Issue 1898: Fix crasher when closing tab with bad SSL constrained popup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1898: Fix crasher when closing tab with bad SSL constrained popup (Closed)

Created:
12 years, 3 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google), beng1

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Closing a tab with a constrained pop-up showing an SSL interstitial would crash the browser. BUG=1966 TEST=Open a page that opens a popup which is served over bad SSL. Close the tab. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2058

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -3 lines)			Patch
M	chrome/browser/ssl_blocking_page.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ssl_uitest.cc	View	1 2	2 chunks	+29 lines, -2 lines	0 comments	Download
A	chrome/test/data/ssl/page_with_unsafe_popup.html	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages