FileUtilTest.Contains failed on Vista Home 64 (and wine)...

FileUtilTest.Contains failed on Vista Home 64 (and wine)
because deleting an empty directory tree fails there with
ERROR_FILE_NOT_FOUND, so allow that return value.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8733

[dank, 2009-01-26 23:38:05]

Hi Aaron,
a test you checked in two weeks ago happens
to fail reliably on my vista home 64 box, here's
a fix...
- Dan

[Aaron Boodman, 2009-01-27 17:14:09]

Thanks for the patch!

http://codereview.chromium.org/18830/diff/1/3
File base/file_util_unittest.cc (right):

http://codereview.chromium.org/18830/diff/1/3#newcode987
Line 987: file_util::Delete(data_dir, true);
With the comments from the other file applied, the assert should go back here.

http://codereview.chromium.org/18830/diff/1/2
File base/file_util_win.cc (right):

http://codereview.chromium.org/18830/diff/1/2#newcode93
Line 93: LOG(INFO) << "SHFileOperation failed, err " << err;
I think we should ignore errors from the file not being there. That seems to be
consistent with what other platforms do, and it makes it an easier API for
clients to deal with.

Also I don't think we should LOG here, just leave that to clients.