thread.cc race fix take 2

Moved Init() before startup_data_->event.Signal() because derived
classes may not be safe to use until Init() has been called.  As an
example, RenderThread() creates it's IPC::SyncChannel in Init(), so it
isn't safe to call Send() method until after.

Update use of a Thread (hit with ui_tests) to no longer require Init()
be called after the startup event is signaled (required old thread
behavior).

Ran a bunch more tests on Windows to try harder to make sure I didn't break anything.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8695

[agl, 2009-01-26 22:45:39]

http://codereview.chromium.org/18824/diff/23/220
File webkit/default_plugin/plugin_impl.h (right):

http://codereview.chromium.org/18824/diff/23/220#newcode353
Line 353: scoped_refptr<PluginInstallationJobMonitorThread>
installation_job_monitor_thread_;
Someone will probably complain about 80 chars... might as well fix it before
hand :)

[John Grabowski, 2009-01-26 22:49:14]

http://codereview.chromium.org/18824/diff/23/220
File webkit/default_plugin/plugin_impl.h (right):

http://codereview.chromium.org/18824/diff/23/220#newcode353
Line 353: scoped_refptr<PluginInstallationJobMonitorThread>
installation_job_monitor_thread_;
On 2009/01/26 22:45:39, agl wrote:
> Someone will probably complain about 80 chars... might as well fix it before
> hand :)

Fixed.

[jeremy, 2009-01-26 23:00:34]

lgtm,
A couple of style nits.

http://codereview.chromium.org/18824/diff/225/228
File webkit/default_plugin/plugin_impl.cc (right):

http://codereview.chromium.org/18824/diff/225/228#newcode42
Line 42: installation_job_monitor_thread_(new
PluginInstallationJobMonitorThread()),
>80 chars

http://codereview.chromium.org/18824/diff/225/229
File webkit/default_plugin/plugin_impl.h (right):

http://codereview.chromium.org/18824/diff/225/229#newcode354
Line 354: installation_job_monitor_thread_;
should be 4 spaces...

http://codereview.chromium.org/18824/diff/225/231
File webkit/default_plugin/plugin_install_job_monitor.h (right):

http://codereview.chromium.org/18824/diff/225/231#newcode19
Line 19: public base::RefCountedThreadSafe<PluginInstallationJobMonitorThread> {
Also 4 spaces.

Personally, I'd actually format this as:
class foo :
    public base::Thread,
    public base:RefCounted...

[John Grabowski, 2009-01-27 00:31:25]

http://codereview.chromium.org/18824/diff/225/228
File webkit/default_plugin/plugin_impl.cc (right):

http://codereview.chromium.org/18824/diff/225/228#newcode42
Line 42: installation_job_monitor_thread_(new
PluginInstallationJobMonitorThread()),
On 2009/01/26 23:00:34, jeremy wrote:
> >80 chars

Fixed

http://codereview.chromium.org/18824/diff/225/229
File webkit/default_plugin/plugin_impl.h (right):

http://codereview.chromium.org/18824/diff/225/229#newcode354
Line 354: installation_job_monitor_thread_;
On 2009/01/26 23:00:34, jeremy wrote:
> should be 4 spaces...

spaced.

http://codereview.chromium.org/18824/diff/225/231
File webkit/default_plugin/plugin_install_job_monitor.h (right):

http://codereview.chromium.org/18824/diff/225/231#newcode19
Line 19: public base::RefCountedThreadSafe<PluginInstallationJobMonitorThread> {
On 2009/01/26 23:00:34, jeremy wrote:
> Also 4 spaces.
> 
> Personally, I'd actually format this as:
> class foo :
>     public base::Thread,
>     public base:RefCounted...

Reformatted.

[agl, 2009-01-27 00:42:09]

LGTM if you want to submit it tonight.