AU: Many minor cleanup changes

AU: Many minor cleanup changes

postinstall: Run postinst twice, once for pre-commit (ie, before we
mark the install partition bootable in the partition table), and
post-commit (for after we do). This behavior is needed for specific
types of firmware update.

download action: flush caches, as we found was necessary in
memento_updater.sh

omaha request prep action: update the names of keys we look for in
lsb-release, also get the AU server url from a file, rather than
hard-code it.

set bootable flag action: GPT support.

also, some misc utility functions.

BUG=None
TEST=attached unittests

[Daniel Erat, 2010-05-03 21:51:18]

LGTM with some comments.

Side question: Any plans to get someone else working on the update code so you
can trade reviews with them? :-)

http://codereview.chromium.org/1881001/diff/1/5
File src/platform/update_engine/omaha_request_prep_action.cc (right):

http://codereview.chromium.org/1881001/diff/1/5#newcode44
src/platform/update_engine/omaha_request_prep_action.cc:44: "en-US",  //lang
add a space between the "//" and "lang"

http://codereview.chromium.org/1881001/diff/1/7
File src/platform/update_engine/omaha_request_prep_action_unittest.cc (right):

http://codereview.chromium.org/1881001/diff/1/7#newcode164
src/platform/update_engine/omaha_request_prep_action_unittest.cc:164:
"CHROMEOS_RELEASE_FOO=CHROMEOS_RELEASE_VERSION=1.2.3.4\n"
are you missing a newline after "CHROMEOS_RELEASE_FOO=" here, or is this
intentional?  MachineIdPersistsTest has the same issue

http://codereview.chromium.org/1881001/diff/1/7#newcode165
src/platform/update_engine/omaha_request_prep_action_unittest.cc:165:
"CHROMEOS_RELEASE_VERSION=0.2.2.3\nCHROMEOS_RELEASE_TRXCK=footrack"));
split this line

http://codereview.chromium.org/1881001/diff/1/7#newcode188
src/platform/update_engine/omaha_request_prep_action_unittest.cc:188:
"CHROMEOS_RELEASE_VERSION=0.2.2.3\nCHROMEOS_RELEASE_TRXCK=footrack"));
and this one too

http://codereview.chromium.org/1881001/diff/1/8
File src/platform/update_engine/postinstall_runner_action.cc (right):

http://codereview.chromium.org/1881001/diff/1/8#newcode10
src/platform/update_engine/postinstall_runner_action.cc:10: #include <vector>
move this include earlier

http://codereview.chromium.org/1881001/diff/1/8#newcode59
src/platform/update_engine/postinstall_runner_action.cc:59:
command.push_back("");
just write:

command.push_back(precommit_ ? "" : "--postcommit");

?

http://codereview.chromium.org/1881001/diff/1/17
File src/platform/update_engine/update_check_action_unittest.cc (right):

http://codereview.chromium.org/1881001/diff/1/17#newcode166
src/platform/update_engine/update_check_action_unittest.cc:166: "");
add "url" comments to this one and the next one

http://codereview.chromium.org/1881001/diff/1/18
File src/platform/update_engine/utils.cc (right):

http://codereview.chromium.org/1881001/diff/1/18#newcode205
src/platform/update_engine/utils.cc:205: if (*it == 'p')
what is a 'p' significant?  you should include a comment about this

http://codereview.chromium.org/1881001/diff/1/19
File src/platform/update_engine/utils.h (right):

http://codereview.chromium.org/1881001/diff/1/19#newcode98
src/platform/update_engine/utils.h:98: // Detects which bootloader this system
uses and returns which via the out
s/returns which/returns it/

[adlr, 2010-05-04 17:22:55]

Thanks. fixed and submitted.

Right now I don't think there are immediate plans to have someone else work on
this w/ me, but I found another person to help you out w/ the reviews, so your
load will lighten.

Also, feel free to send me reviews for windowmanager or whatever stuff.

http://codereview.chromium.org/1881001/diff/1/5
File src/platform/update_engine/omaha_request_prep_action.cc (right):

http://codereview.chromium.org/1881001/diff/1/5#newcode44
src/platform/update_engine/omaha_request_prep_action.cc:44: "en-US",  //lang
On 2010/05/03 21:51:18, Daniel Erat wrote:
> add a space between the "//" and "lang"

Done.

http://codereview.chromium.org/1881001/diff/1/7
File src/platform/update_engine/omaha_request_prep_action_unittest.cc (right):

http://codereview.chromium.org/1881001/diff/1/7#newcode164
src/platform/update_engine/omaha_request_prep_action_unittest.cc:164:
"CHROMEOS_RELEASE_FOO=CHROMEOS_RELEASE_VERSION=1.2.3.4\n"
On 2010/05/03 21:51:18, Daniel Erat wrote:
> are you missing a newline after "CHROMEOS_RELEASE_FOO=" here, or is this
> intentional?  MachineIdPersistsTest has the same issue

Yeah, that's intentional. A mis-parsing class might think the release version is
1.2.3.4, noth 0.2.2.3.

http://codereview.chromium.org/1881001/diff/1/7#newcode165
src/platform/update_engine/omaha_request_prep_action_unittest.cc:165:
"CHROMEOS_RELEASE_VERSION=0.2.2.3\nCHROMEOS_RELEASE_TRXCK=footrack"));
On 2010/05/03 21:51:18, Daniel Erat wrote:
> split this line

Done.

http://codereview.chromium.org/1881001/diff/1/7#newcode188
src/platform/update_engine/omaha_request_prep_action_unittest.cc:188:
"CHROMEOS_RELEASE_VERSION=0.2.2.3\nCHROMEOS_RELEASE_TRXCK=footrack"));
On 2010/05/03 21:51:18, Daniel Erat wrote:
> and this one too

Done.

http://codereview.chromium.org/1881001/diff/1/8
File src/platform/update_engine/postinstall_runner_action.cc (right):

http://codereview.chromium.org/1881001/diff/1/8#newcode10
src/platform/update_engine/postinstall_runner_action.cc:10: #include <vector>
On 2010/05/03 21:51:18, Daniel Erat wrote:
> move this include earlier

Done.

http://codereview.chromium.org/1881001/diff/1/8#newcode59
src/platform/update_engine/postinstall_runner_action.cc:59:
command.push_back("");
On 2010/05/03 21:51:18, Daniel Erat wrote:
> just write:
> 
> command.push_back(precommit_ ? "" : "--postcommit");
> 
> ?

Done.

http://codereview.chromium.org/1881001/diff/1/17
File src/platform/update_engine/update_check_action_unittest.cc (right):

http://codereview.chromium.org/1881001/diff/1/17#newcode166
src/platform/update_engine/update_check_action_unittest.cc:166: "");
On 2010/05/03 21:51:18, Daniel Erat wrote:
> add "url" comments to this one and the next one

Done.

http://codereview.chromium.org/1881001/diff/1/18
File src/platform/update_engine/utils.cc (right):

http://codereview.chromium.org/1881001/diff/1/18#newcode205
src/platform/update_engine/utils.cc:205: if (*it == 'p')
On 2010/05/03 21:51:18, Daniel Erat wrote:
> what is a 'p' significant?  you should include a comment about this

Done.

http://codereview.chromium.org/1881001/diff/1/19
File src/platform/update_engine/utils.h (right):

http://codereview.chromium.org/1881001/diff/1/19#newcode98
src/platform/update_engine/utils.h:98: // Detects which bootloader this system
uses and returns which via the out
On 2010/05/03 21:51:18, Daniel Erat wrote:
> s/returns which/returns it/

Done.