Issue 188005: Added possibility of miscompiled regexp to verfifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 188005: Added possibility of miscompiled regexp to verfifier. (Closed)

Created:
11 years, 3 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Added possibility of miscompiled regexp to verfifier.

Patch Set 1 #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	src/objects.h	View		1 chunk	+6 lines, -2 lines	0 comments	Download
	M	src/objects-debug.cc	View		1 chunk	+5 lines, -2 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 3 months ago (2009-09-02 08:15:14 UTC) #2

LGTM

http://codereview.chromium.org/188005/diff/1/2
File src/objects-debug.cc (right):

http://codereview.chromium.org/188005/diff/1/2#newcode776
Line 776: || (is_native ? ascii_data->IsCode() : ascii_data->IsByteArray()));
Put the || on the previous line and indent:

ASSERT(ascii_data... ||
       (is_native ...));

http://codereview.chromium.org/188005/diff/1/2#newcode779
Line 779: || (is_native ? uc16_data->IsCode() : uc16_data->IsByteArray()));
Indentation as above.

Expand Messages | Collapse Messages