Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 18780: Adjust SDCH problem code histogram.... (Closed)

Created:
11 years, 11 months ago by jar (doing other things)
Modified:
9 years, 7 months ago
Reviewers:
huanr
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Adjust SDCH problem code histogram. Tentative SDCH was not properly noted, and this caused some confusion in the SDCH problem codes. I corrected the assertion of a tentative sdch, and renumbered (to new numbers) all problem codes that might have been varied. r=huanr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8698

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M net/base/filter.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/base/filter_unittest.cc View 3 1 chunk +1 line, -1 line 0 comments Download
M net/base/sdch_manager.h View 1 2 3 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jar (doing other things)
11 years, 11 months ago (2009-01-26 21:32:50 UTC) #1
huanr
11 years, 11 months ago (2009-01-26 21:58:05 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698