Issue 18770: Fix snapshot generation on Visual Studio. Compiling source files generated in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18770: Fix snapshot generation on Visual Studio. Compiling source files generated in... (Closed)

Created:
11 years, 11 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix snapshot generation on Visual Studio. Compiling source files generated inside the same project is flaky with VisualStudio when building with Incredibuild. So I splitted the mksnapshot.exe generation, snapshot.cc generation and snapshot.cc compilation in three different projects.

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -45 lines)			Patch
M	tools/visual_studio/README.txt	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	tools/visual_studio/v8.sln	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	tools/visual_studio/v8_snapshot.vcproj	View	1 chunk	+2 lines, -43 lines	0 comments	Download
A	tools/visual_studio/v8_snapshot_cc.vcproj	View	1 chunk	+92 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

11 years, 11 months ago (2009-01-27 16:10:17 UTC) #2

On 2009/01/26 19:36:45, M-A wrote:
> 

LGTM if you update the README.txt file in the directory holding the V8 .vcproj
files

We just need to remember to update project dependencies in Chromium when V8 is
updated.

Expand Messages | Collapse Messages