Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: webkit/glue/webplugin.h

Issue 18768: POSIX: gfx::NativeViewId and CrossProcessEvent (Closed)
Patch Set: Addressing Brett's comments Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/webkit_glue.h ('k') | webkit/glue/webplugin_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webplugin.h
diff --git a/webkit/glue/webplugin.h b/webkit/glue/webplugin.h
index 7350df4238f9a99cd64d5e00a70e6467d363e6bb..773752f73ea92a06167efd2fa2d9a281004cbf15 100644
--- a/webkit/glue/webplugin.h
+++ b/webkit/glue/webplugin.h
@@ -11,11 +11,11 @@
#include "base/basictypes.h"
#include "base/file_path.h"
#include "base/gfx/rect.h"
+#include "base/gfx/native_widget_types.h"
-// TODO(port): type typedefs are obviously incorrect on non-Windows
+// TODO(port): this typedef is obviously incorrect on non-Windows
// platforms, but now a lot of code now accidentally depends on them
// existing. #ifdef out these declarations and fix all the users.
-typedef struct HWND__* HWND;
typedef void* HANDLE;
class GURL;
@@ -58,7 +58,7 @@ struct WebPluginInfo {
// Describes the new location for a plugin window.
struct WebPluginGeometry {
- HWND window;
+ gfx::NativeView window;
gfx::Rect window_rect;
// Clip rect (include) and cutouts (excludes), relative to
// window_rect origin.
@@ -89,7 +89,8 @@ class WebPlugin {
// The pump_messages_event is a event handle which is valid only for
// windowless plugins and is used in NPP_HandleEvent calls to pump messages
// if the plugin enters a modal loop.
- virtual void SetWindow(HWND window, HANDLE pump_messages_event) = 0;
+ virtual void SetWindow(gfx::NativeView window,
+ HANDLE pump_messages_event) = 0;
// Cancels a pending request.
virtual void CancelResource(int id) = 0;
virtual void Invalidate() = 0;
« no previous file with comments | « webkit/glue/webkit_glue.h ('k') | webkit/glue/webplugin_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698