Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: chrome/renderer/render_view.h

Issue 18768: POSIX: gfx::NativeViewId and CrossProcessEvent (Closed)
Patch Set: Addressing Brett's comments Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/render_thread.cc ('k') | chrome/renderer/render_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/render_view.h
diff --git a/chrome/renderer/render_view.h b/chrome/renderer/render_view.h
index 8933655c669393df249ae010614cb69a367dedc3..49b0be1c62c0e96bdc70aa24fa50e450c942cd33 100644
--- a/chrome/renderer/render_view.h
+++ b/chrome/renderer/render_view.h
@@ -91,7 +91,7 @@ class RenderView : public RenderWidget,
// (in which case we treat this RenderView as a top level window).
static RenderView* Create(
RenderThreadBase* render_thread,
- HWND parent_hwnd,
+ gfx::NativeViewId parent_hwnd,
base::WaitableEvent* modal_dialog_event, // takes ownership
int32 opener_id,
const WebPreferences& webkit_prefs,
@@ -111,7 +111,7 @@ class RenderView : public RenderWidget,
return static_cast<WebView*>(webwidget());
}
- HWND host_window() const {
+ gfx::NativeViewId host_window() const {
return host_window_;
}
@@ -334,7 +334,7 @@ class RenderView : public RenderWidget,
// Initializes this view with the given parent and ID. The |routing_id| can be
// set to 'MSG_ROUTING_NONE' if the true ID is not yet known. In this case,
// CompleteInit must be called later with the true ID.
- void Init(HWND parent,
+ void Init(gfx::NativeViewId parent,
base::WaitableEvent* modal_dialog_event, // takes ownership
int32 opener_id,
const WebPreferences& webkit_prefs,
@@ -396,11 +396,7 @@ class RenderView : public RenderWidget,
void GoToEntryAtOffset(int offset);
// RenderView IPC message handlers
-#if defined(OS_WIN)
- void OnCreatingNewAck(HWND parent);
-#else
- void OnCreatingNewAck();
-#endif
+ void OnCreatingNewAck(gfx::NativeViewId parent);
void SendThumbnail();
void OnPrintPage(const ViewMsg_PrintPage_Params& params);
void OnGetPrintedPagesCount(const ViewMsg_Print_Params& params);
« no previous file with comments | « chrome/renderer/render_thread.cc ('k') | chrome/renderer/render_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698