Issue 18764: Change FileStream to use FilePath instead of wstring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18764: Change FileStream to use FilePath instead of wstring. (Closed)

Created:
11 years, 11 months ago by Erik does not do reviews

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Change FileStream to use FilePath instead of wstring. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8663

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -14 lines)			Patch
M	chrome/browser/bookmarks/bookmark_html_writer.cc	View	4 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/common/unzip.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/file_stream.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	net/base/file_stream_posix.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/base/file_stream_unittest.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	net/base/file_stream_win.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/base/upload_data_stream.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/url_request/url_request_file_job.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

darin (slow to review)

To/FromWStringHack ?? those names suggest that there is some better way to get/set the raw ...

11 years, 11 months ago (2009-01-26 17:53:30 UTC) #2

darin (slow to review)

nevermind... i see that those two callsites just need other code to change first.

11 years, 11 months ago (2009-01-26 17:54:45 UTC) #3

LGTM