Reduce the size of a release sample shell by 55k.

Reduce the size of a release sample shell by 55k.

The ExternalReferenceTable population code was code driven, using the list macro callbacks to call an Add() function.  Additionally this Add() function was defined in the class defintion, making it inline.  This caused this single function to be ~100k of code.  It is now mostly table driven, but there are still some cases left as code, and these could be improved in the future for further reduction in binary size.

[Dean McNamee, 2009-01-26 14:59:59]

This change is kinda ugly, but this code was ugly before I got to it.  This
function was the second largest function in a release build of Google Chrome.

[Mads Ager (chromium), 2009-01-26 15:21:27]

LGTM

[olehougaard, 2009-01-26 15:24:40]

LGTM

http://codereview.chromium.org/18761/diff/1/2
File src/serialize.cc (right):

http://codereview.chromium.org/18761/diff/1/2#newcode499
Line 499: };
Consider moving this to class scope. I don't think we have any other types with
function scope.

http://codereview.chromium.org/18761/diff/1/2#newcode501
Line 501: static const RefTableEntry ref_table[] = {
Same with static const tables.

http://codereview.chromium.org/18761/diff/1/2#newcode575
Line 575: 
Ditto.

[Dean McNamee, 2009-01-26 15:55:44]

Additionally, I pulled the code out of the constructor and into PopulateTable. 
This better follows the style guide (only trivial work in a constructor), and
due to ABI reasons for generating 2 constructors, this now saves a total of
57920 bytes on a final release shell.

I find it makes more sense to have the types along with the definitions, since
they aren't really part of the class, but more of a implementation detail of the
function.  If you think that's crazy, let me know.

On 2009/01/26 15:24:40, olehougaard wrote:
> LGTM
> 
> http://codereview.chromium.org/18761/diff/1/2
> File src/serialize.cc (right):
> 
> http://codereview.chromium.org/18761/diff/1/2#newcode499
> Line 499: };
> Consider moving this to class scope. I don't think we have any other types
with
> function scope.
> 
> http://codereview.chromium.org/18761/diff/1/2#newcode501
> Line 501: static const RefTableEntry ref_table[] = {
> Same with static const tables.
> 
> http://codereview.chromium.org/18761/diff/1/2#newcode575
> Line 575: 
> Ditto.