Porting in chrome/views/

Porting in chrome/views/

Some highlights: label, throbber. And others.

[Paweł Hajdan Jr., 2009-01-26 14:38:47]

I tested this change on Windows by compiling chrome.exe and using it for a
while. I didn't encounter any odd issues with throbber.

[sgk, 2009-01-26 17:39:56]

lgtm

[Evan Martin, 2009-01-26 18:53:51]

+brett for gurl question

http://codereview.chromium.org/18757/diff/1/3
File chrome/views/label.cc (right):

http://codereview.chromium.org/18757/diff/1/3#newcode191
Line 191: return GURL(WideToUTF8(text_));
This should be WideToASCII, I think.

http://codereview.chromium.org/18757/diff/1/7
File chrome/views/throbber.cc (right):

http://codereview.chromium.org/18757/diff/1/7#newcode42
Line 42: timer_.Start(frame_time_ - TimeDelta::FromMilliseconds(10),
I wonder where this 10 came from.  The previous author should've made it a named
constant.  :~(

http://codereview.chromium.org/18757/diff/1/8
File chrome/views/throbber.h (right):

http://codereview.chromium.org/18757/diff/1/8#newcode45
Line 45: base::Time start_time_;
I know it's not your code, but could you add comments to the variables you're
changing?

[brettw, 2009-01-26 19:07:22]

http://codereview.chromium.org/18757/diff/1/3
File chrome/views/label.cc (right):

http://codereview.chromium.org/18757/diff/1/3#newcode191
Line 191: return GURL(WideToUTF8(text_));
I think UTF-8 is correct, we don't want to lose the non-ASCII data. GURL will
escape things as necessary.

[Ben Goodger (Google), 2009-01-26 19:13:52]

OK

http://codereview.chromium.org/18757/diff/1/8
File chrome/views/throbber.h (right):

http://codereview.chromium.org/18757/diff/1/8#newcode8
Line 8: #define CHROME_VIEWS_THROBBER_H__
may as well fix this while you're here. one trailing undescore.

[Paweł Hajdan Jr., 2009-01-26 20:02:51]

Issue updated. Please check if you like the comments.

[Evan Martin, 2009-01-26 20:38:27]

On 2009/01/26 20:02:51, Paweł Hajdan Jr. wrote:
> Issue updated. Please check if you like the comments.

lg

[brettw, 2009-01-26 20:50:52]

LGTM