Issue 18752: Added a lookup request to the debugger protocol to retreive an object from it...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18752: Added a lookup request to the debugger protocol to retreive an object from it... (Closed)

Created:
11 years, 11 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Added a lookup request to the debugger protocol to retreive an object from it's handle. Added a test for testing handles when using both the 'evaluate' and the 'lookup' request. Committed: http://code.google.com/p/v8/source/detail?r=1153

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+236 lines, -0 lines)			Patch
M	src/debug-delay.js	View		2 chunks	+25 lines, -0 lines	0 comments	Download
M	src/mirror-delay.js	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A	test/mjsunit/debug-handle.js	View	1 2	1 chunk	+199 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/18752/diff/1/2 File test/mjsunit/debug-handle.js (right): http://codereview.chromium.org/18752/diff/1/2#newcode1 Line 1: // Copyright 2008 the V8 project authors. ...

11 years, 11 months ago (2009-01-26 13:33:33 UTC) #2

Søren Thygesen Gjesse

11 years, 11 months ago (2009-01-26 13:42:28 UTC) #3

http://codereview.chromium.org/18752/diff/1/2
File test/mjsunit/debug-handle.js (right):

http://codereview.chromium.org/18752/diff/1/2#newcode1
Line 1: // Copyright 2008 the V8 project authors. All rights reserved.
On 2009/01/26 13:33:34, Mads Ager wrote:
> 2009

Done.

Expand Messages | Collapse Messages