Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 18750: * Remember to check for end of string even where we... (Closed)

Created:
11 years, 11 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

* Remember to check for end of string even where we know the character class must match. Thanks to Mads and Christian for finding this bug Committed: http://code.google.com/p/v8/source/detail?r=1150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M src/jsregexp.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/regexp-macro-assembler.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/regexp-macro-assembler-ia32.h View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Erik Corry
11 years, 11 months ago (2009-01-26 12:47:59 UTC) #1
Mads Ager (chromium)
Please add a regression test. :-)
11 years, 11 months ago (2009-01-26 12:50:01 UTC) #2
Christian Plesner Hansen
11 years, 11 months ago (2009-01-26 12:52:16 UTC) #3
Lgtm

Powered by Google App Engine
This is Rietveld 408576698