Issue 18719: Sort file refs and build refs by UUID so Xcode doesn't resort them on...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18719: Sort file refs and build refs by UUID so Xcode doesn't resort them on...

Created:
11 years, 11 months ago by aharper

Modified:
7 years, 7 months ago

Reviewers:
Avi (use Gerrit), sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Sort file refs and build refs by UUID so Xcode doesn't resort them on the next modification.

Patch Set 1 #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	tools/xcodebodge/xcodebodge.py	View		3 chunks	+6 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

I don't read Python, nor know the project file format, but it works for me ...

11 years, 11 months ago (2009-01-23 19:39:08 UTC) #2

sgk

11 years, 11 months ago (2009-01-26 18:53:00 UTC) #3

lgtm (modulo 80 chars).

http://codereview.chromium.org/18719/diff/1/2
File tools/xcodebodge/xcodebodge.py (right):

http://codereview.chromium.org/18719/diff/1/2#newcode557
Line 557: self._sections['PBXFileReference'].sort(cmp=lambda x,y: cmp(x.uuid,
y.uuid))
Nit:  80 chars.

http://codereview.chromium.org/18719/diff/1/2#newcode575
Line 575: self._sections['PBXFileReference'].sort(cmp=lambda x,y: cmp(x.uuid,
y.uuid))
Nit:  80 chars.

Expand Messages | Collapse Messages