Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 18717: Generate additional .vcproj files in miscellaneous top-level components.... (Closed)

Created:
11 years, 11 months ago by sgk
Modified:
9 years, 5 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Generate additional .vcproj files in miscellaneous top-level components. This also updates the .vcproj files themselves to fix minor stylistic incompatibilities with the rest. Affected .vcproj files: * No change (byte-for-byte identical): media\build\media.vcproj media\build\media_player.vcproj media\build\media_unittests.vcproj google_update\ondemand_updates.vcproj * Remove .\ prefix where inconsistent with the rest of a filelist: rlz\rlz.vcproj breakpad\breakpad_handler.vcproj * Add empty <ToolFiles>, <References> and <Globals> sections: breakpad\breakpad_sender.vcproj * Add explicit RootNamespace attribute: sdch\sdch.vcproj * Use Windows-canonical \ separators: sdch\sdch.vcproj * Remove unnecessary Filter and UniqueIdentifier attributes from <Filter> declarations: sdch\sdch.vcproj Additional cleanups along for the ride: * Split breakpad\SConscript logic into separate breakpad_{handler,sender}.scons files. * Add a media\media_player.scons configuration.

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+534 lines, -113 lines) Patch
M breakpad/SConscript View 1 2 3 1 chunk +9 lines, -48 lines 0 comments Download
A breakpad/breakpad_handler.scons View 1 chunk +96 lines, -0 lines 0 comments Download
M breakpad/breakpad_handler.vcproj View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
A breakpad/breakpad_sender.scons View 1 chunk +63 lines, -0 lines 0 comments Download
M breakpad/breakpad_sender.vcproj View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M google_update/SConscript View 1 2 3 1 chunk +32 lines, -2 lines 0 comments Download
M media/media.scons View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M media/media_lib.scons View 1 2 3 2 chunks +67 lines, -22 lines 0 comments Download
A media/media_player.scons View 1 chunk +62 lines, -0 lines 0 comments Download
M media/media_unittests.scons View 1 2 3 1 chunk +65 lines, -7 lines 0 comments Download
M rlz/SConscript View 1 2 3 1 chunk +35 lines, -2 lines 0 comments Download
M rlz/rlz.vcproj View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdch/SConscript View 1 2 3 2 chunks +86 lines, -17 lines 0 comments Download
M sdch/sdch.vcproj View 1 2 3 5 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sgk
Re: the changes to sdch.vcproj, I don't believe we need the Filter and UniqueIdentifier attributes, ...
11 years, 11 months ago (2009-01-23 18:53:21 UTC) #1
Nicolas Sylvain
LGTM (parts of the scons files are rubber stamped)
11 years, 11 months ago (2009-01-23 19:12:47 UTC) #2
M-A Ruel
mostly rubber stamped lgtm http://codereview.chromium.org/18717/diff/201/205 File media/media_lib.scons (right): http://codereview.chromium.org/18717/diff/201/205#newcode61 Line 61: if not env.Bit('mac'): I ...
11 years, 11 months ago (2009-01-23 19:23:29 UTC) #3
sgk
11 years, 11 months ago (2009-01-23 19:51:07 UTC) #4
http://codereview.chromium.org/18717/diff/201/205
File media/media_lib.scons (right):

http://codereview.chromium.org/18717/diff/201/205#newcode61
Line 61: if not env.Bit('mac'):
On 2009/01/23 19:23:29, M-A wrote:
> I don't understand why you keep that part.

Done.

Powered by Google App Engine
This is Rietveld 408576698