scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_dll_.json - Issue 1871583004: Revert "Remove references to crash_service, which is no longer needed."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_dll_.json

Issue 1871583004: Revert "Remove references to crash_service, which is no longer needed." (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_dbg_.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsan.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_dll_.json

diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_dll_.json b/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_dll_.json

index 5a69716ddde186e8ac392947ee52a61e076b60cf..0966b9e70f7c6390e2da368a1dfe83bc4a6634dd 100644

--- a/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_dll_.json

+++ b/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_dll_.json

@@ -217,7 +217,8 @@

"--",

"base_unittests",

"chromium_builder_tests",

- "content_unittests"

+ "content_unittests",

+ "crash_service"

"cwd": "[SLAVE_BUILD]",

"name": "compile",

@@ -230,6 +231,17 @@

"cmd": [

"python",

"-u",

+ "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\chromium\\run_crash_handler.py",

+ "--target",

+ "Release"

+ ],

+ "cwd": "[SLAVE_BUILD]",

+ "name": "start_crash_service"

+ },

+ {

+ "cmd": [

+ "python",

+ "-u",

"[BUILD]\\goma\\diagnose_goma_log.py"

"cwd": "[SLAVE_BUILD]",