Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Issue 18710: Optimizes check for Smi range in the code generator.... (Closed)

Created:
11 years, 11 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Optimizes check for Smi range in the code generator. The check whether a 32-bit signed integer is in the Smi range is now Sign bit( value + 0x40000000 ) == 0, done with a single cmp instruction. Committed: http://code.google.com/p/v8/source/detail?r=1134

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M src/codegen-ia32.cc View 1 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
William Hesse
11 years, 11 months ago (2009-01-23 12:16:41 UTC) #1
Kevin Millikin (Chromium)
11 years, 11 months ago (2009-01-23 12:20:46 UTC) #2
In the rest of the code we use lowercase hex digits (eg, 0xdeadbeed).

Powered by Google App Engine
This is Rietveld 408576698