Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: src/api.h

Issue 18707: Split handle scopes into an internal version and a version accessible... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | src/api.cc » ('j') | src/apiutils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.h
===================================================================
--- src/api.h (revision 1129)
+++ src/api.h (working copy)
@@ -28,6 +28,7 @@
#ifndef V8_API_H_
#define V8_API_H_
+#include "apiutils.h"
#include "factory.h"
namespace v8 {
@@ -159,45 +160,6 @@
};
-class ImplementationUtilities {
- public:
- static v8::Handle<v8::Primitive> Undefined();
- static v8::Handle<v8::Primitive> Null();
- static v8::Handle<v8::Boolean> True();
- static v8::Handle<v8::Boolean> False();
-
- static int GetNameCount(ExtensionConfiguration* that) {
- return that->name_count_;
- }
-
- static const char** GetNames(ExtensionConfiguration* that) {
- return that->names_;
- }
-
- static v8::Arguments NewArguments(Local<Value> data,
- Local<Object> holder,
- Local<Function> callee,
- bool is_construct_call,
- void** argv, int argc) {
- return v8::Arguments(data, holder, callee, is_construct_call, argv, argc);
- }
-
- // Introduce an alias for the handle scope data to allow non-friends
- // to access the HandleScope data.
- typedef v8::HandleScope::Data HandleScopeData;
-
- static HandleScopeData* CurrentHandleScope() {
- return &v8::HandleScope::current_;
- }
-
-#ifdef DEBUG
- static void ZapHandleRange(void** begin, void** end) {
- v8::HandleScope::ZapRange(begin, end);
- }
-#endif
-};
-
-
class Utils {
public:
static bool ReportApiFailure(const char* location, const char* message);
@@ -275,7 +237,7 @@
template <class T>
v8::internal::Handle<T> v8::internal::Handle<T>::EscapeFrom(
- HandleScope* scope) {
+ v8::HandleScope* scope) {
return Utils::OpenHandle(*scope->Close(Utils::ToLocal(*this)));
}
@@ -408,11 +370,11 @@
List<Handle<Object> > saved_contexts_;
bool ignore_out_of_memory;
// This is only used for threading support.
- ImplementationUtilities::HandleScopeData handle_scope_data_;
+ v8::ImplementationUtilities::HandleScopeData handle_scope_data_;
static void Iterate(ObjectVisitor* v,
- List<void**>* blocks,
- ImplementationUtilities::HandleScopeData* handle_data);
+ List<void**>* blocks,
+ v8::ImplementationUtilities::HandleScopeData* handle_data);
char* RestoreThreadHelper(char* from);
char* ArchiveThreadHelper(char* to);
@@ -474,13 +436,14 @@
for (int i = extensions; i > 1; --i) {
void** block = blocks.RemoveLast();
#ifdef DEBUG
- ImplementationUtilities::ZapHandleRange(block, &block[kHandleBlockSize]);
+ v8::ImplementationUtilities::ZapHandleRange(block,
+ &block[kHandleBlockSize]);
#endif
DeleteArray(block);
}
spare = reinterpret_cast<Object**>(blocks.RemoveLast());
#ifdef DEBUG
- ImplementationUtilities::ZapHandleRange(
+ v8::ImplementationUtilities::ZapHandleRange(
reinterpret_cast<void**>(spare),
reinterpret_cast<void**>(&spare[kHandleBlockSize]));
#endif
« no previous file with comments | « include/v8.h ('k') | src/api.cc » ('j') | src/apiutils.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698