Issue 187015: Add beginDragWithFiles to EventSendingController. Also implement WebKitClient...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 187015: Add beginDragWithFiles to EventSendingController. Also implement WebKitClient... (Closed)

Created:
11 years, 3 months ago by jianli

Modified:
9 years, 6 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add beginDragWithFiles to EventSendingController. Also implement WebKitClientImpl::fileExists. With these, we're able to enable all drag-file related layout tests. BUG=19884 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25683

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -10 lines)			Patch
M	webkit/glue/webkitclient_impl.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	webkit/tools/test_shell/event_sending_controller.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/event_sending_controller.cc	View	1	4 chunks	+33 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dglazkov

11 years, 3 months ago (2009-09-03 02:51:40 UTC) #2

LGTM.

http://codereview.chromium.org/187015/diff/4001/5003
File webkit/tools/test_shell/event_sending_controller.cc (right):

http://codereview.chromium.org/187015/diff/4001/5003#newcode609
Line 609: result->SetNull();
I would put this at the end --not that it matters.

Expand Messages | Collapse Messages