Issue 187012: Add chrome_dll.pdb and chrome_exe.pdb to the zip file we...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 187012: Add chrome_dll.pdb and chrome_exe.pdb to the zip file we... (Closed)

Created:
11 years, 3 months ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/tools/buildbot/scripts/slave/

Visibility:
Public.

Description

Add chrome_dll.pdb and chrome_exe.pdb to the zip file we share between machines. If this creates a too big performance impact, i'll revert. BUG=20910 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25242

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	zip_build.py	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

11 years, 3 months ago (2009-09-02 21:24:18 UTC) #2

lgtm

http://codereview.chromium.org/187012/diff/1/2
File zip_build.py (right):

http://codereview.chromium.org/187012/diff/1/2#newcode71
Line 71: # Special case for chrome. Add back all the chrome*.pdb files to the
list.
You can move it inside the IsWindows() condition even if it's a hack.

Expand Messages | Collapse Messages