Issue 1869001: Add inlined code for (constant SHL smi), ported from ia32 to x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1869001: Add inlined code for (constant SHL smi), ported from ia32 to x64. (Closed)

Created:
10 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add inlined code for (constant SHL smi), ported from ia32 to x64. Improve type information on ia32 version of code. Committed: http://code.google.com/p/v8/source/detail?r=4571

Patch Set 4 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -31 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View	2 3	8 chunks	+20 lines, -18 lines	0 comments	Download
	M	src/x64/codegen-x64.cc	View	1 2 3	5 chunks	+83 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/1869001/diff/1002/3002 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1869001/diff/1002/3002#newcode2174 src/ia32/codegen-ia32.cc:2174: TypeInfo right_type_info = operand.type_info(); Why make a variable ...

10 years, 7 months ago (2010-05-04 07:48:20 UTC) #2

William Hesse

10 years, 7 months ago (2010-05-04 14:10:34 UTC) #3

http://codereview.chromium.org/1869001/diff/1002/3002
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/1869001/diff/1002/3002#newcode2174
src/ia32/codegen-ia32.cc:2174: TypeInfo right_type_info = operand.type_info();
On 2010/05/04 07:48:20, Lasse Reichstein wrote:
> Why make a variable for something that's only used once anyway? Is the
> information lost in the register shuffling below?

Exactly, the information is lost in the register shuffling below.

http://codereview.chromium.org/1869001/diff/1002/3002#newcode2200
src/ia32/codegen-ia32.cc:2200: } else {
On 2010/05/04 07:48:20, Lasse Reichstein wrote:
> Consider using
> } else if (...) {
> 

Done.

Expand Messages | Collapse Messages

Issue 1869001: Add inlined code for (constant SHL smi), ported from ia32 to x64. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages