Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: base/file_util_linux.cc

Issue 1869: POSIX/Linux related changes to file_util.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/file_util_linux.cc
===================================================================
--- base/file_util_linux.cc (revision 2056)
+++ base/file_util_linux.cc (working copy)
@@ -4,7 +4,10 @@
#include "base/file_util.h"
+#include <fcntl.h>
+
#include <string>
+#include <vector>
#include "base/logging.h"
#include "base/string_util.h"
@@ -23,9 +26,49 @@
}
bool CopyFile(const std::wstring& from_path, const std::wstring& to_path) {
- // TODO(erikkay): implement
- NOTIMPLEMENTED();
- return false;
+ int infile = open(WideToUTF8(from_path).c_str(), O_RDONLY);
+ if (infile < 0)
+ return false;
+
+ int outfile = creat(WideToUTF8(to_path).c_str(), 0666);
Dean McNamee 2008/09/12 13:59:46 Is this the right thing to do? I would think we s
Erik does not do reviews 2008/09/12 16:00:50 My understanding is that both creat() and open() u
+ if (outfile < 0) {
+ close(infile);
+ return false;
+ }
+
+ const size_t kBufferSize = 32768;
Dean McNamee 2008/09/12 13:59:46 If this is 32k, it would be nice as 32 * 1024;
+ std::vector<char> buffer(kBufferSize);
+ bool result = true;
+
+ while (result) {
+ ssize_t bytes_read = read(infile, &buffer[0], buffer.size());
+ if (bytes_read < 0) {
+ result = false;
+ break;
+ }
+ if (bytes_read == 0)
+ break;
+ // Allow for partial writes
+ ssize_t bytes_written_per_read = 0;
+ do {
+ ssize_t bytes_written_partial = write(
+ outfile,
+ &buffer[bytes_written_per_read],
+ bytes_read - bytes_written_per_read);
+ if (bytes_written_partial < 0) {
+ result = false;
+ break;
+ }
+ bytes_written_per_read += bytes_written_partial;
+ } while (bytes_written_per_read < bytes_read);
+ }
+
+ if (close(infile) < 0)
+ result = false;
+ if (close(outfile) < 0)
+ result = false;
+
+ return result;
}
} // namespace file_util
« no previous file with comments | « base/SConscript ('k') | base/file_util_posix.cc » ('j') | base/file_util_posix.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698